GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Tests from #4479 by markekraus · Pull Request #4512 · PowerShell/PowerShell

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Aug 6, 2017

Copy link
Copy Markdown
Contributor

My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markekraus
Fix Tests from PowerShell#4479
f2234b4
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Aug 6, 2017

Copy link
Copy Markdown

Mark Kraus (@markekraus),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Aug 6, 2017
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Aug 7, 2017
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed.

The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md

Look for the section titled 'Requesting additional tests for a PR'
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
[Feature]
e6786ad
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) I have pushed an empty commit to execute the feature tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Thank you. I will make sure to do this in the future.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) The tests pass now.

  • AppVeyor L7736
  • AppVeyor L7737
  • AppVeyor L7739
  • AppVeyor L7926
  • AppVeyor L7927
  • AppVeyor L7929

The Travis CI failure appears to be unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Restarted the tests on Travis CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markekraus

Mark Kraus (markekraus) commented Aug 7, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) All Travis CI Tests passing now as well

  • Travis CI L8863
  • Travis CI L8864
  • Travis CI L8865
  • Travis CI L9029
  • Travis CI L9030
  • Travis CI L9031
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) Can you have a quick look? This fixes the daily build failure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Dongbo Wang (daxian-dbw) August 7, 2017 21:21
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 7, 2017
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit e4060ab into PowerShell:master Aug 7, 2017
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Mark Kraus (@markekraus) Thanks for fixing the tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markekraus Mark Kraus (markekraus) mentioned this pull request Aug 8, 2017
Add support for Content Headers to BasicHtmlWebResponseObject and HtmlWebResponseObject #4494
Merged
@markekraus
Mark Kraus (markekraus) deleted the WebCmdletTestFix branch August 25, 2017 00:12
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @adityapatwardhan
Fix Tests from PowerShell#4479 (PowerShell#4512)
1242b09 
* Fix Tests from PowerShell#4479

* [Feature]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markekraus @msftclas @adityapatwardhan @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.