GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Only push to NuGet for Full Build (cron) by TravisEz13 · Pull Request #4517 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Currently, every merge is also publishing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13 Travis Plunk (TravisEz13) added the WG-Maintainers-Build specific to affecting the build label Aug 7, 2017
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Aditya Patwardhan (adityapatwardhan) August 7, 2017 17:59
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Aug 7, 2017
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 8, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found another issue, we seem to be updating the badge on full build, including the one with [Feature]. We need a way to identify a CRON build and then do nuget publish and badge update.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/travis.ps1 Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 8, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in allready -> already

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 8, 2017
View reviewed changes
Comment thread tools/travis.ps1 Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 8, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also published if it is [Feature] run?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 8, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if we merge a feature... that is equivalent to a daily build, I'm fine with it. If it's a PR, it won't publish. And if you squash merge, you will likely, remove the [Feature] from the commit message.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 8, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, a true merge would change the description of the last commit message too. Only merging to master using the rebase option would have this possible effect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 9, 2017

Copy link
Copy Markdown
Member Author

The badge issue is being fixed in #4536
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Aug 9, 2017
View reviewed changes
Comment thread tools/travis.ps1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 9, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging a PR to master, if the commit message happen to have [Feature] tag, we will publish the nuget package as well. Is that desired? Maybe we should use $isDailyBuild instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 9, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, and updated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 3 commits August 9, 2017 15:43
@TravisEz13
Only push to NuGet for Full Build (cron)
ec4c04e
@TravisEz13
fix spelling error in already
3c00391
@TravisEz13
Address PR feedback
b4bcbf1
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the OnlyPushToNugetOnFullBuilds branch from 8afb947 to b4bcbf1 Compare August 9, 2017 22:44
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 9, 2017
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 9, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit b3ebdaf into PowerShell:master Aug 11, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the OnlyPushToNugetOnFullBuilds branch August 11, 2017 15:50
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Only push to NuGet for Full Build (cron) (PowerShell#4517)
528f6a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @daxian-dbw @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.