GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove last-modified from headers from travis CI script by JamesWTruher · Pull Request #4522 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Aug 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

It causes a no such resource error when used

When invoke-webrequest is invoked, the call fails with a resource not found error and the badge is not updated. The documentation is pretty spotty with regard to what that resource (last-modified) could have done. It should be enough to set the cache-control header value to let browsers know to refresh the badge value rather than pulling it from cache.

this change should enable the PowerShell main page to report the proper state of the daily build on travis.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
Remove last-modified from headers as it causes a failure when updatin…
65835d4 
…g the daily badge
@JamesWTruher
James Truher (JamesWTruher) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) August 7, 2017 22:38
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 7, 2017
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 7, 2017
View reviewed changes
Comment thread tools/travis.ps1
@@ -50,7 +50,6 @@ function Set-DailyBuildBadge
$headers = @{

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$now is not used any more. We should remove it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still being used in x-ms-date

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JamesWTruher James Truher (JamesWTruher) Aug 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still used - two lines higher

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Can we add more description in the PR as to how this change fixes the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 7, 2017
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 7, 2017

Copy link
Copy Markdown
Member

Also, AppVeyor failed in filesystem provider tests. Can we investigate?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

James Truher (@JamesWTruher) Please also add the issue it fixes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher

James Truher (JamesWTruher) commented Aug 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

it looks like failure is in new test code that went in on 8/2 from jeffbi, i'm not sure whether this is a new failure, with a change only in travis.ps1 I'm having difficulty believing my change caused this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher

James Truher (JamesWTruher) commented Aug 7, 2017

Copy link
Copy Markdown
Collaborator Author

Aditya Patwardhan (@adityapatwardhan) updated description
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher

James Truher (JamesWTruher) commented Aug 7, 2017

Copy link
Copy Markdown
Collaborator Author

is there a way to restart the job in appveyor?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 7, 2017

Copy link
Copy Markdown
Member

James Truher (@JamesWTruher) Restarted the AppVeyor build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 7, 2017
View reviewed changes
@TravisEz13 Travis Plunk (TravisEz13) added the WG-Maintainers-Build specific to affecting the build label Aug 8, 2017
@TravisEz13
Travis Plunk (TravisEz13) merged commit 0e4cd63 into PowerShell:master Aug 8, 2017
@JamesWTruher James Truher (JamesWTruher) mentioned this pull request Aug 15, 2017
Travis CI nightly build badge does not update #4518
Closed
@JamesWTruher
James Truher (JamesWTruher) deleted the jameswtruher/travisbadgefix10 branch September 23, 2023 05:33
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @TravisEz13
Remove last-modified from headers as it causes a failure when updatin…
e2126a8 
…g the daily badge (PowerShell#4522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JamesWTruher @adityapatwardhan @TravisEz13 @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.