GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up ShellExecute code to use the .NET Core implementation by daxian-dbw · Pull Request #4523 · PowerShell/PowerShell

Clean up ShellExecute code to use the .NET Core implementation #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aditya Patwardhan (adityapatwardhan) merged 7 commits into PowerShell:master from daxian-dbw:shellexecute
Aug 10, 2017

Uh oh!

There was an error while loading. Please reload this page.
Merged

Clean up ShellExecute code to use the .NET Core implementation #4523

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82636e3
Clean up ShellExecuteHelper and enable ShellExecute in NativeCommandP…
daxian-dbw Aug 5, 2017
6ac56ab
Minor fix
daxian-dbw Aug 5, 2017
f99c35a
[Feature] Fix NativeCommandProcessor to clean up in case an exception…
daxian-dbw Aug 7, 2017
7d375eb
[Feature] Update tests
daxian-dbw Aug 8, 2017
5494c7f
[Feature] Address comments
daxian-dbw Aug 8, 2017
16f459e
address one more comment
daxian-dbw Aug 8, 2017
c7c9394
Address some more comments
daxian-dbw Aug 9, 2017
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor fix
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
daxian-dbw committed Aug 5, 2017
commit 6ac56abd229c310a0c628d816d165dda48d03fa7

There are no files selected for viewing

1 change: 1 addition & 0 deletions 1 src/System.Management.Automation/engine/NativeCommandProcessor.cs
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,7 @@ private void InitNativeProcess()
string executable = Platform.IsLinux ? "xdg-open" : /* OS X */ "open";
startInfo.Arguments = "\"" + startInfo.FileName + "\" " + startInfo.Arguments;
startInfo.FileName = executable;
startInfo.UseShellExecute = false;
}

try
Expand Down
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.