GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add an additional acceptance test for the PowerShellGet module by bmanikm · Pull Request #4531 · PowerShell/PowerShell

Conversation

@bmanikm

@bmanikm Manikyam Bavandla (bmanikm) commented Aug 8, 2017

Copy link
Copy Markdown
Contributor
  • This acceptance test will ensure that there are no regressions in PowerShell build w.r.t. to adding a .NET type in PowerShellGet module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bmanikm
Add an additional acceptance test for the PowerShellGet module
4f8eb46
@bmanikm Manikyam Bavandla (bmanikm) assigned Aditya Patwardhan (adityapatwardhan) Aug 8, 2017
@bmanikm
Manikyam Bavandla (bmanikm) requested review from Krishna C Vutukuri (Krishna-Vutukuri), Aditya Patwardhan (adityapatwardhan) and sergei (vors) August 8, 2017 21:56
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Aug 8, 2017
@bmanikm
Removed 'BVT' tag
096a376
Krishna-Vutukuri
Krishna C Vutukuri (Krishna-Vutukuri) reviewed Aug 9, 2017
View reviewed changes
Comment thread test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1
function Remove-InstalledModules
{
Get-InstalledModule -Name $ContosoServer -AllVersions -ErrorAction SilentlyContinue | Uninstall-Module -Force
Get-InstalledModule -Name $ContosoServer -AllVersions -ErrorAction SilentlyContinue | PowerShellGet\Uninstall-Module -Force

@Krishna-Vutukuri Krishna C Vutukuri (Krishna-Vutukuri) Aug 9, 2017

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might throw right? Do you want to ignore those errors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@bmanikm Manikyam Bavandla (bmanikm) Aug 9, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be any errors in uninstalling the test module, otherwise other test cases will fail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested a review from Jianyun (jianyunt) August 9, 2017 20:04
@jianyunt

Jianyun (jianyunt) commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

:shipit:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 0bfee35 into PowerShell:master Aug 10, 2017
@bmanikm
Manikyam Bavandla (bmanikm) deleted the AddPowerShellGetAcceptanceTest branch August 11, 2017 17:49
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bmanikm @adityapatwardhan
Add an additional acceptance test for the PowerShellGet module (Power…
08383bd 
…Shell#4531)

* Add an additional acceptance test for the PowerShellGet module

* Removed 'BVT' tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vors sergei (vors) Awaiting requested review from vors
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@jianyunt Jianyun (jianyunt) Awaiting requested review from jianyunt
1 more reviewer
@Krishna-Vutukuri Krishna C Vutukuri (Krishna-Vutukuri) Krishna-Vutukuri left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@bmanikm @jianyunt @Krishna-Vutukuri @msftclas @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.