GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update nano server insider for new bulid by TravisEz13 · Pull Request #4555 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 11, 2017

Copy link
Copy Markdown
Member

Also, Address #4310

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) added 2 commits August 11, 2017 12:40
@TravisEz13
Update dockerfile to support new nanoserver-insider build
64ace14
@TravisEz13
add http://label-schema.org/rc1/ labels
2d5b636
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Aug 11, 2017
@TravisEz13
Travis Plunk (TravisEz13) requested a review from Aditya Patwardhan (adityapatwardhan) August 11, 2017 20:14
@TravisEz13 Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw) Aug 11, 2017
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Aug 11, 2017
View reviewed changes
Comment thread docker/release/nanoserver-insider/Dockerfile

# setx /M fails on nanoserver-insider, setting the user path
# Set the path
RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell"

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, setx /M is not necessary on nanoserver because it's a single user OS, correct?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, they fixed the container to use the per user path.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Aug 11, 2017
View reviewed changes
Comment thread docker/release/nanoserver-insider/Dockerfile
# Set the path
RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell"

CMD ["C:\\Program Files\\PowerShell\\PowerShell.exe"]

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docker/README.md:

Due to an issue with the container not picking up the path, you must specify the path when running a command on the command line.

Looks like the PATH issue has been fixed, so the document should be updated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TravisEz13 Travis Plunk (TravisEz13) Aug 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note that it will be fixed soon. I have to setup a build machine matching the exact build of the container, which might take me some time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 11, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Travis Plunk (TravisEz13) and others added 2 commits August 11, 2017 16:50
@TravisEz13
Add note that issue is fixed soon
e9ec1cf
@daxian-dbw
Make the note a quote. It's more eye-catching
5ea8efe
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 12, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 7ae955f into PowerShell:master Aug 12, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the Update_NanoServerInsider_for_New_Bulid branch August 12, 2017 15:39
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Update nano server insider for new bulid (PowerShell#4555)
a38c563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@TravisEz13 @daxian-dbw @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.