GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Package only from root plus powershell by TravisEz13 · Pull Request #4569 · PowerShell/PowerShell

Conversation

Travis Plunk (TravisEz13) commented Aug 14, 2017

Copy link

Copy Markdown

Member

fixes #4492

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) added 4 commits

August 14, 2017 08:25


          Add RootInfo to PSOptions

0459d0b


          stop packaging release if RootInfo is not valid

abbc969


          add ability to skip release checks

ad3192a


          skip release checking when packaging in CI

54c56d9

Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label

Aug 14, 2017

Travis Plunk (TravisEz13) added the WG-Maintainers-Build specific to affecting the build label

Aug 14, 2017

Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and sergei (vors)

August 14, 2017 15:46

Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw)

Aug 14, 2017

Dongbo Wang (daxian-dbw) reviewed

Aug 14, 2017

View reviewed changes

Comment thread

tools/packaging/packaging.psm1 Outdated

		Write-Warning "Skipping release checks."
		}

		if(!$Script:Options.RootInfo.IsValid -and -not $SkipReleaseChecks.IsPresent){

Dongbo Wang (daxian-dbw) Aug 14, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an elseif is better here.

elseif (!$Script:Options.RootInfo.IsValid) {
    throw $Script:Options.RootInfo.Warning
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

build.psm1 Outdated

		{
		$RootInfo += @{Warning = "Please ensure you repo is at the root of the file system and named 'PowerShell' (example: '$($RootInfo.ValidPath)'), when building and packaging for release!" }
		$RootInfo += @{IsValid = $false}
		Write-Warning -Message $RootInfo.Warning

Dongbo Wang (daxian-dbw) Aug 14, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't write the warning in New-PSOptions. We only care about the root path when it comes to a release build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tools/travis.ps1 Outdated

		$packages += Start-PSPackage @packageParams -Type AppImage
		$packages = @(Start-PSPackage @packageParams -SkipReleaseChecks)
		# Packaging AppImage depends on the deb package
		$packages += Start-PSPackage @packageParams -Type AppImage -SkipReleaseChecks

Dongbo Wang (daxian-dbw) Aug 14, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space before -SkipReleaseChecks, in both line 182 and 184

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Aug 14, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) and others added 4 commits

August 14, 2017 15:50


          remove warning for invalid root

2783c81


          remove extra space

842899e


          simply conditional using elseif

faf529d


          Remove extra space

3d2ba14

Dongbo Wang (daxian-dbw) approved these changes

Aug 14, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) reviewed

Aug 15, 2017

View reviewed changes

Comment thread

build.psm1 Outdated

		$RootInfo = @{RepoPath = $PSScriptRoot}

		# the valid root is the root of the filesystem and the folder PowerShell
		$RootInfo += @{ValidPath = Join-Path -Path ([system.io.path]::GetPathRoot($RootInfo.RepoPath)) -ChildPath 'PowerShell' }

Dongbo Wang (daxian-dbw) Aug 15, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment about the way you use Hashtable: in this scenario it's better to write script like

$RootInfo['ValidPath'] = Join-Path -Path ([system.io.path]::GetPathRoot($RootInfo.RepoPath)) -ChildPath 'PowerShell'
$RootInfo['IsValid'] = $true
$RootInfo['Warning'] = "Please ensure you repo is at the root of the file system and named 'PowerShell' (example: '$($RootInfo.ValidPath)'), when building and packaging for release!"

It's much less expensive than adding two hashtables.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Address PR feedback regarding adding hashtables

d6c0ce7

Dongbo Wang (daxian-dbw) approved these changes

Aug 15, 2017

View reviewed changes

Dongbo Wang (daxian-dbw) merged commit 0ca44f1 into PowerShell:master

Aug 15, 2017

Travis Plunk (TravisEz13) deleted the PackageOnlyFromRootPlusPowerShell branch

August 15, 2017 23:21

Aditya Patwardhan (adityapatwardhan) mentioned this pull request

Aug 16, 2017

Fixed typo in New-PSOptions #4600

Merged

jla3378 mentioned this pull request

Apr 11, 2021

macOS packaging and codesigning #15203

Closed

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Package only from the powershell folder at the root directory (PowerS…

a9c5bef

…hell#4569)

Reviewers

Dongbo Wang (daxian-dbw)

daxian-dbw approved these changes

sergei (vors)

Awaiting requested review from vors

Aditya Patwardhan (adityapatwardhan)

Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Dongbo Wang (daxian-dbw)

Labels

WG-Maintainers-Build

specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Official mac build should not contain alias in the path

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.