GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up FullCLR related scripts/docs by daxian-dbw · Pull Request #4580 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Aug 15, 2017

Copy link
Copy Markdown
Member

Related to #4357

This PR includes following changes:

  1. Remove FulLCLR related build script in build.psm1
  2. Remove commented out FullCLR related scripts in AppVeyor.psm1
  3. Remove FullCLR test file test/fullclr/PowerShellGithubDev.Tests.ps1
  4. Remove FullCLR related doc content.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
[Feature] Clean up FullCLR related scripts/docs
aadaef0
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Aug 15, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Ilya (iSazonov) August 15, 2017 23:07
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from James Truher (JamesWTruher) and Joey Aiello (joeyaiello) as code owners August 15, 2017 23:07
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 15, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) removed request for James Truher (JamesWTruher) and Joey Aiello (joeyaiello) August 15, 2017 23:07
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 15, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread build.psm1
{
$Command += "Import-Module '$Pester'; "
}
$Command += "Import-Module '$Pester'; "

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 15, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this, now that we have module autoloading?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Aug 16, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it as the -Pester parameter can be given a different path than the one in our module path.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iSazonov
Ilya (iSazonov) approved these changes Aug 16, 2017
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 16, 2017
View reviewed changes

@TravisEz13 Travis Plunk (TravisEz13) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit feeb8e1 into PowerShell:master Aug 16, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the build branch August 16, 2017 22:06
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
[Feature] Clean up FullCLR related scripts/docs (PowerShell#4580)
5465a17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@daxian-dbw @TravisEz13 @adityapatwardhan @iSazonov @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.