GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove src\Microsoft.PowerShell.Workflow.ServiceCore by daxian-dbw · Pull Request #4589 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Aug 15, 2017

Copy link
Copy Markdown
Member

Related to #4357

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Remove src\Microsoft.PowerShell.Workflow.ServiceCore
6c2fe65
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Aug 15, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Aditya Patwardhan (adityapatwardhan) August 15, 2017 23:34
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 15, 2017
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 16, 2017
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Aug 16, 2017

Copy link
Copy Markdown
Collaborator

Is Workflow depredicated?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Aug 16, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Aug 16, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't remove Workflow code until @PowerShell/powershell-committee has closed on this. This has been an open topic for the committee
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Aug 16, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Aug 16, 2017

Copy link
Copy Markdown
Member

@PowerShell/powershell-committee is fine with proceeding to remove the workflow code. PowerShell workflow is deprecated. Joey Aiello (@joeyaiello) probably needs another blog post... Although CoreCLR has support for workflow, it doesn't support XAML which is what all the PowerShell workflow code depends upon. Our data indicates that most customers use PowerShell workflow specifically for parallel execution. We have an RFC to make it easier with PowerShell script so we are ok removing support entirely.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 1605a98 into PowerShell:master Aug 17, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the Microsoft.PowerShell.Workflow.ServiceCore branch August 18, 2017 18:19
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
Remove src\Microsoft.PowerShell.Workflow.ServiceCore (PowerShell#4589)
e9da877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

Committee-Reviewed PS-Committee has reviewed this and made a decision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@daxian-dbw @iSazonov @SteveL-MSFT @adityapatwardhan @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.