GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Modify travis build to upload a daily build badge based on platform by JamesWTruher · Pull Request #4689 · PowerShell/PowerShell

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Aug 28, 2017

Copy link
Copy Markdown
Collaborator

change README.md to view a platform specific badge
This will give us better visibility into our platform specific builds, and improve efficiency when investigating a build failure

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher James Truher (JamesWTruher) assigned Travis Plunk (TravisEz13) Aug 28, 2017
@JamesWTruher
James Truher (JamesWTruher) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) August 28, 2017 17:39
@JamesWTruher
James Truher (JamesWTruher) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners August 28, 2017 17:39
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 28, 2017
@JamesWTruher James Truher (JamesWTruher) changed the title Modify travis build to upload a daily build based on platform Modify travis build to upload a daily build badge based on platform Aug 28, 2017
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Aug 29, 2017
View reviewed changes
Comment thread README.md Outdated

@SteveL-MSFT Steve Lee (SteveL-MSFT) Aug 29, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Apple has standardized on macOS vs OSX, so we should be consistent with macOS (ignore the fact we have $isOSX, unfortunately it's a breaking change now)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JamesWTruher James Truher (JamesWTruher) Aug 29, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we be rather self consistent? I believe that it will be more confusing for our users unless we also make the change in our variables

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Aug 29, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we should be consistent with the variables, but that's outside the scope of this PR. I think at least within the README.md, we can be consistent on using macOS (which it is currently)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@JamesWTruher James Truher (JamesWTruher) Aug 29, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve Lee (@SteveL-MSFT) updated to include this change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Aug 29, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still shows OSX, did you push?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JamesWTruher James Truher (JamesWTruher) Aug 31, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve Lee (@SteveL-MSFT) yup

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) force-pushed the jameswtruher/travisBuildFix02 branch from 9246c70 to be8c381 Compare August 29, 2017 20:08
@JamesWTruher
Modify travis build to upload a daily build based on platform
d08c899 
change README.md to view a platform specific badge
@JamesWTruher
James Truher (JamesWTruher) force-pushed the jameswtruher/travisBuildFix02 branch from be8c381 to d08c899 Compare August 29, 2017 20:47
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Aug 31, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher

James Truher (JamesWTruher) commented Sep 1, 2017

Copy link
Copy Markdown
Collaborator Author

Travis Plunk (@TravisEz13) can we get this in?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit cfb2913 into PowerShell:master Sep 5, 2017
@JamesWTruher
James Truher (JamesWTruher) deleted the jameswtruher/travisBuildFix02 branch September 23, 2023 05:45
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@JamesWTruher @TravisEz13
Modify travis build to upload a daily build based on platform (PowerS…
ee44cfb 
…hell#4689)

change README.md to view a platform specific badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JamesWTruher @SteveL-MSFT @msftclas @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.