GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Move WebCmdlets HTTPS tests to WebListener by markekraus · Pull Request #4733 · PowerShell/PowerShell

Conversation

Mark Kraus (markekraus) commented Aug 31, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Resolves #4719

Move badssl.com tests to local WebListener to remove reliance on external site for test.
Move HTTPS tests to their own context

Made separate commits to make it a bit easier to see the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) added 2 commits

August 31, 2017 17:23


          Move HTTPS tests to WebListener

ddb0e07


          Move Invoke-WebRequest HTTPS Tests to Context

4b2a915

Microsoft Contribution License Agreements (msftclas) commented Aug 31, 2017

Copy link

Copy Markdown

Mark Kraus (@markekraus),
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label

Aug 31, 2017


          [Feature] Move Invoke-RestMethod HTTPS Tests to Context

00cae5b

Mark Kraus (markekraus) force-pushed the HttpsLocalTests branch from a98f667 to 00cae5b Compare

August 31, 2017 23:02

Dongbo Wang (daxian-dbw) requested review from James Truher (JamesWTruher), Steve Lee (SteveL-MSFT) and Dan Travison (dantraMSFT)

September 1, 2017 00:04

Dongbo Wang (daxian-dbw) assigned Ilya (iSazonov)

Sep 1, 2017

Steve Lee (SteveL-MSFT) approved these changes

Sep 1, 2017

View reviewed changes

Steve Lee (SteveL-MSFT) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purely porting of the code looks fine. Some extra whitespace that came from the original test code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

		Select-Object -ExpandProperty Content \|
		ConvertFrom-Json

		$result.Status \| Should Be 'FAILED'

Steve Lee (SteveL-MSFT) Sep 1, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between Status and pipe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) Sep 1, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

		Select-Object -ExpandProperty Content \|
		ConvertFrom-Json

		$result.Status \| Should Be 'OK'

Steve Lee (SteveL-MSFT) Sep 1, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between Status and pipe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) Sep 1, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

		$uri = Get-WebListenerUrl -Https -Test 'Cert'
		$result = Invoke-RestMethod -Uri $uri -SkipCertificateCheck

		$result.Status \| Should Be 'FAILED'

Steve Lee (SteveL-MSFT) Sep 1, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between Status and pipe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) Sep 1, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

		$certificate = Get-WebListenerClientCertificate
		$result = Invoke-RestMethod -uri $uri -Certificate $certificate -SkipCertificateCheck

		$result.Status \| Should Be 'OK'

Steve Lee (SteveL-MSFT) Sep 1, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space between Status and pipe

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) Sep 1, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) commented Sep 1, 2017

Copy link

Copy Markdown

Member

AppVeyor failure is due to #4720

markekraus reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          [feature] Address PR Feedback

e68c95f

Dan Travison (dantraMSFT) approved these changes

Sep 1, 2017

View reviewed changes

James Truher (JamesWTruher) approved these changes

Sep 1, 2017

View reviewed changes

James Truher (JamesWTruher) left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this - it's great that we can move these from using off box connections! I have only one non-blocking question below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated


		# Test skipped on macOS pending support for Client Certificate Authentication
		# https://github.com/PowerShell/PowerShell/issues/4650
		It "Verifies Invoke-WebRequest Certificate Authentication Successful with -Certificate" -skip:$IsOSX {

James Truher (JamesWTruher) Sep 1, 2017

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is eventually going to be run on mac, could you make this -pending:$IsOSX? we track pending tests more closely than skipped tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mark Kraus (markekraus) Sep 1, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will switch them to pending. I was asked to "skip" them but perhaps they didn't mean literally to use -skip

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) Sep 1, 2017

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated


		# Test skipped on macOS pending support for Client Certificate Authentication
		# https://github.com/PowerShell/PowerShell/issues/4650
		It "Verifies Invoke-RestMethod Certificate Authentication Successful with -Certificate" -skip:$IsOSX {

James Truher (JamesWTruher) Sep 1, 2017

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above - not sure whether this should be -pending rather than -skip

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          [feature] Mark Cert Auth Tests Pending

e41d1dd

-skip -> -pending

Ilya (iSazonov) merged commit 87db370 into PowerShell:master

Sep 1, 2017

Ilya (iSazonov) commented Sep 1, 2017

Copy link

Copy Markdown

Collaborator

Mark Kraus (@markekraus) Many thanks! I was happy with WebListener, now I am twice happy 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mark Kraus (markekraus) deleted the HttpsLocalTests branch

September 22, 2017 20:38

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Move WebCmdlets HTTPS tests to WebListener (PowerShell#4733)

5b23e2f

* Move HTTPS tests to WebListener

* Move Invoke-WebRequest HTTPS Tests to Context

* [Feature] Move Invoke-RestMethod HTTPS Tests to Context

.

* [feature] Address PR Feedback

* [feature] Mark Cert Auth Tests Pending

-skip -> -pending

Reviewers

Ilya (iSazonov)

iSazonov left review comments

Steve Lee (SteveL-MSFT)

SteveL-MSFT approved these changes

+2 more reviewers

James Truher (JamesWTruher)

JamesWTruher approved these changes

Dan Travison (dantraMSFT)

dantraMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

Mark Kraus (markekraus) commented Aug 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Aug 31, 2017

Uh oh!

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Sep 1, 2017

Uh oh!

James Truher (JamesWTruher) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Sep 1, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mark Kraus (markekraus) commented Aug 31, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.