GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace 'Windows PowerShell' with 'PowerShell' in resx files by iSazonov · Pull Request #4758 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Sep 6, 2017 •
edited by daxian-dbw
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Address #3345

Motivation

After removing FullCLR from the repo we can clean up message strings and replace 'Windows PowerShell' with 'PowerShell' in resx files.

Fix

Find and replace 'Windows PowerShell' with 'PowerShell' in .resx files. Then revert some replacements (related workflows, "Windows PowerShell 3.0 and higher" and so on).

Additional considerations

The PR doesn't address *.cs files (which have 'Windows PowerShell' strings in comments).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Replace 'Windows PowerShell' with 'PowerShell Core' in resx files
c8954b3
@iSazonov
Ilya (iSazonov) requested review from James Truher (JamesWTruher), Paul Higinbotham (PaulHigin), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT), Dongbo Wang (daxian-dbw) and Jason Shirk (lzybkr) as code owners September 6, 2017 12:02
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Sep 6, 2017
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Sep 6, 2017
@iSazonov
Fix test
7fca929
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Sep 6, 2017

Copy link
Copy Markdown
Member

I think we should replace Windows PowerShell with just PowerShell and not PowerShell Core
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dantraMSFT

Dan Travison (dantraMSFT) commented Sep 6, 2017

Copy link
Copy Markdown
Contributor

Steve Lee (@SteveL-MSFT): I agree; Core identifies an underlying technology; not PowerShell itself.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Sep 6, 2017

Copy link
Copy Markdown
Collaborator Author

I agree. Will do.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dantraMSFT
Dan Travison (dantraMSFT) reviewed Sep 7, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/resources/Debugger.resx Outdated
</data>
<data name="RunspaceDebuggingNoHostRunspaceOrDebugger" xml:space="preserve">
<value>Cannot debug Runspace. The host has no debugger. Try debugging the Runspace inside the Windows PowerShell console or the Windows PowerShell ISE, both of which have built-in debuggers.</value>
<value>Cannot debug Runspace. The host has no debugger. Try debugging the Runspace inside the PowerShell Core console or the Visual Studio Code, both of which have built-in debuggers.</value>

@dantraMSFT Dan Travison (dantraMSFT) Sep 7, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or the [](start = 122, length = 6)

Suggestion: 'or the Visual Studio Code' is rather cumbersome to read IMHO.
How about 'or with Visual Studio Code.'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Replace 'PowerShell Core' with 'PowerShell'
49c08c3
@iSazonov Ilya (iSazonov) changed the title Replace 'Windows PowerShell' with 'PowerShell Core' in resx files Replace 'Windows PowerShell' with 'PowerShell' in resx files Sep 7, 2017
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Sep 7, 2017
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/resources/NewObjectStrings.resx Outdated
</data>
<data name="ApartmentNotSupported" xml:space="preserve">
<value>{0} Please note that Single-Threaded Apartment is not supported in PowerShell Core.</value>
<value>{0} Please note that Single-Threaded Apartment is not supported in PowerShell.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave this one since it's Core specific (until I get my PR submitted)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/HostInterfaceExceptionsStrings.resx Outdated
</data>
<data name="HostFunctionNotImplemented" xml:space="preserve">
<value>A command that prompts the user failed because the host program or the command type does not support user interaction. Try a host program that supports user interaction, such as the Windows PowerShell Console or Windows PowerShell ISE, and remove prompt-related commands from command types that do not support user interaction, such as Windows PowerShell workflows.</value>
<value>A command that prompts the user failed because the host program or the command type does not support user interaction. Try a host program that supports user interaction, such as the PowerShell Console, and remove prompt-related commands from command types that do not support user interaction, such as PowerShell workflows.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove mention of workflows which isn't supported

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/Modules.resx Outdated
</data>
<data name="WorkflowModuleNotSupportedInPowerShellCore" xml:space="preserve">
<value>Cannot load the workflow module '{0}'. Workflow is not supported in PowerShell Core.</value>
<value>Cannot load the workflow module '{0}'. Workflow is not supported in PowerShell.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put Core back as this is specific to Core

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/MshSnapInCmdletResources.resx Outdated
</data>
<data name="CustomPSSnapInNotSupportedInPowerShellCore" xml:space="preserve">
<value>The custom Windows PowerShell snap-in is not supported in PowerShell Core.</value>
<value>The custom PowerShell snap-in is not supported in PowerShell.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put Core back as this is specific to Core not supporting PSSnapin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/MshSnapinInfo.resx Outdated
</data>
<data name="MonadEngineRegistryAccessFailed" xml:space="preserve">
<value>Unable to access Windows PowerShell PowerShellEngine registry information.</value>
<value>Unable to access PowerShell PowerShellEngine registry information.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems redundant, perhaps just: PowerShell Engine registry

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/ParserStrings.resx Outdated
</data>
<data name="CantActivateDocumentInPowerShellCore" xml:space="preserve">
<value>Cannot run a document in PowerShell Core: {0}.</value>
<value>Cannot run a document in PowerShell: {0}.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed this so this error should no longer come up? If it's still applicable, put back Core

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about applicable but CantActivateDocumentInPowerShellCore is still used in NativeCommandProcessor.cs for Nano and IoT.

Reverted.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
</data>
<data name="CSCmdsPowerShellCoreShellNotModifiable" xml:space="preserve">
<value>Session configuration "{0}" is a PowerShell Core-based shell. Please use PowerShell Core to modify it.</value>
<value>Session configuration "{0}" is a PowerShell-based shell. Please use PowerShell to modify it.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error seems Core specific, please revert

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
</data>
<data name="CSCmdsWindowsPowerShellCoreNotModifiable" xml:space="preserve">
<value>Session configuration "{0}" is a Windows PowerShell-based shell. Please use Windows PowerShell to modify it.</value>
<value>Session configuration "{0}" is a PowerShell-based shell. Please use PowerShell to modify it.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error seems Windows PS specific, please revert

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
</data>
<data name="NetFrameWorkV2NotInstalled" xml:space="preserve">
<value>The Microsoft .NET Framework 2.0, which is required for Windows PowerShell 2.0, is not installed. Install the .NET Framework 2.0 and retry.</value>
<value>The Microsoft .NET Framework 2.0, which is required for PowerShell 2.0, is not installed. Install the .NET Framework 2.0 and retry.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows PS specific, please revert although PS2.0 is deprecated, so maybe this error and code should be removed in another PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/resources/RemotingErrorIdStrings.resx Outdated
</data>
<data name="InvalidProcessorArchitecture" xml:space="preserve">
<value>PowerShell Core does not support WOW64. The binary must match the architecture of the processor.</value>
<value>PowerShell does not support WOW64. The binary must match the architecture of the processor.</value>

@SteveL-MSFT Steve Lee (SteveL-MSFT) Sep 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core specific, please revert

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Sep 7, 2017

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Revert 'Core' in some messages
2f09673
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Sep 7, 2017
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 3c59736 into PowerShell:master Sep 7, 2017
@iSazonov

Ilya (iSazonov) commented Sep 8, 2017

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) Thanks for fast review!
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) deleted the remove-windows-powershell branch September 8, 2017 03:57
@iSazonov Ilya (iSazonov) mentioned this pull request Oct 7, 2017
Question: Are module manifest keys (other than marked) specific to Windows? #2064
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @daxian-dbw
Replace 'Windows PowerShell' with 'PowerShell' in resx files (PowerSh…
3274881 
…ell#4758)

Replace 'Windows PowerShell' with 'PowerShell' in '.resx' files where appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@lzybkr Jason Shirk (lzybkr) Awaiting requested review from lzybkr
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iSazonov @SteveL-MSFT @dantraMSFT @daxian-dbw @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.