GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update version of PSDesiredStateConfiguration in project files by Indhukrishna · Pull Request #4979 · PowerShell/PowerShell

Conversation

@Indhukrishna

@Indhukrishna Indhu Sivaramakrishnan (Indhukrishna) commented Oct 2, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR has the project dependency changes for updating version of PSDesiredStateConfiguration module. The module has been fixed to enable Dsc configuration compilation on Windows with PowerShell 6.0.0.0

Resolves #4570

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan and SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Indhukrishna
Update version of PSDesiredStateConfiguration in project files
801f21b
@Indhukrishna Indhu Sivaramakrishnan (Indhukrishna) self-assigned this Oct 2, 2017
@Indhukrishna
Indhu Sivaramakrishnan (Indhukrishna) requested a review from Dongbo Wang (daxian-dbw) October 2, 2017 23:09
@Indhukrishna
Indhu Sivaramakrishnan (Indhukrishna) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) as code owners October 2, 2017 23:09
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Dongbo Wang (daxian-dbw) and unassigned Indhu Sivaramakrishnan (Indhukrishna) Oct 2, 2017
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 2, 2017
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 2, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Indhukrishna
Indhu Sivaramakrishnan (Indhukrishna) merged commit 417e988 into PowerShell:master Oct 3, 2017
@Indhukrishna
Indhu Sivaramakrishnan (Indhukrishna) deleted the insivara/UpdatePSDesiredStateConfiguration/1710 branch October 3, 2017 04:07
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 3, 2017

Copy link
Copy Markdown
Member

Do we have tests for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Indhukrishna

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 3, 2017

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) We have some tests that we are adding to the other repo. When we make more updates to this module, we will add those tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 3, 2017

Copy link
Copy Markdown
Member

Indhu Sivaramakrishnan (@Indhukrishna) it would be great if you can add some basic tests to this repo to make sure things don't accidentally get broken
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Indhukrishna

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 3, 2017

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Got it. Will do as soon as I am back in office.
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 4, 2017

Copy link
Copy Markdown
Member

Indhu Sivaramakrishnan (@Indhukrishna) Please use a rebase merge unless there is a need to preserve the history
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@Indhukrishna
Merge pull request PowerShell#4979 from Indhukrishna/insivara/UpdateP…
6f0fbc9 
…SDesiredStateConfiguration/1710

Update version of PSDesiredStateConfiguration in project files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DSC Configurations should work on windows

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Indhukrishna @SteveL-MSFT @TravisEz13 @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.