GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add tests for Dsc configuration compilation on Windows by Indhukrishna · Pull Request #5011 · PowerShell/PowerShell

Conversation

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 4, 2017

Copy link

Copy Markdown

Contributor

This PR adds tests for testing Dsc Configuration compilation on Windows. #4570

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add tests for Dsc configuration compilation on Windows

ff9e32d

Indhu Sivaramakrishnan (Indhukrishna) requested a review from Dongbo Wang (daxian-dbw)

October 4, 2017 21:37

Indhu Sivaramakrishnan (Indhukrishna) added the Area-DSC Desired State Configuration issues label

Oct 4, 2017

Steve Lee (SteveL-MSFT) requested a review from Travis Plunk (TravisEz13)

October 4, 2017 21:44

Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13)

Oct 4, 2017

Arie Heinrich (ArieHein) commented Oct 8, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

for the sake of my OCD, please align the "Ensure" with "Destination Path" and align all three resources at the same column position. :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fix Indendation

73687ef

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 9, 2017

Copy link

Copy Markdown

Contributor Author

Arie Heinrich (@ArieHein) Thanks for the feedback. I opened it in VSCode and ISE and fixed it. But in the Github UI, I can see that the indentation is still messed up. How do I fix this properly?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) requested changes

Oct 9, 2017

View reviewed changes

Comment thread

test/powershell/Modules/PSDesiredStateConfiguration/MOF-Compilation.Tests.ps1 Outdated

		}

		DSCTestConfig
		"@).Invoke()

Travis Plunk (TravisEz13) Oct 9, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to put this in the form of {[Scr...Invoke()}|should not throw and/or verify the expected file gets created.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a PR to your branch to make this change: Indhukrishna#1
I'll make the change directly, once the tests pass if you would like me to.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 10, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have passed on Linux and Windows. I'm going to push to your branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/PSDesiredStateConfiguration/MOF-Compilation.Tests.ps1 Outdated

		}

		DSCTestConfig
		"@).Invoke()

Travis Plunk (TravisEz13) Oct 9, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Indhu Sivaramakrishnan (Indhukrishna) added 5 commits

October 9, 2017 15:14


          Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

3cee181

…o insivara/AddDscCompilationTests/1710


          Update test to assert that scriptblock invocation does not throw

714b127


          Update tests to fix indentation

2964f4b


          Update test to ensure that MOF is produced after compilation

84e52a4


          Update indentation

8d1ac8c

Travis Plunk (TravisEz13) previously requested changes

Oct 10, 2017

View reviewed changes

Comment thread

test/powershell/Modules/PSDesiredStateConfiguration/MOF-Compilation.Tests.ps1 Outdated


		DSCTestConfig
		"@).Invoke()
		"@).Invoke() \| Should Not Throw;

Travis Plunk (TravisEz13) Oct 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests should fail... a script block should be piped to should not throw

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) reviewed

Oct 10, 2017

View reviewed changes

Comment thread

test/powershell/Modules/PSDesiredStateConfiguration/MOF-Compilation.Tests.ps1 Outdated

		"@).Invoke()
		"@).Invoke()

		Test-Path -Path .\DSCTestConfig\localhost.mof \| Should Be $True

Travis Plunk (TravisEz13) Oct 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to verify a file exists, please use `` | should exist` , it results it better errors

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Indhu Sivaramakrishnan (Indhukrishna) Oct 10, 2017

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Indhu Sivaramakrishnan (Indhukrishna) and others added 3 commits

October 10, 2017 12:21


          Update file exist check from Test-Path to Should Exist per code revie…

5a13c3f

…w feedback


          Update name of MOF file for Wordpress configuration

99a0400


          update tests to use should not throw

ef7400b

Travis Plunk (TravisEz13) dismissed their stale review

October 10, 2017 21:33

issues resolved

Travis Plunk (TravisEz13) previously requested changes

Oct 10, 2017

View reviewed changes

Comment thread

test/powershell/Modules/PSDesiredStateConfiguration/MOF-Compilation.Tests.ps1 Outdated


		".\DSCTestConfig\localhost.mof" \| Should Exist

		Remove-Item -Force -Recurse -Path DSCTestConfig

Travis Plunk (TravisEz13) Oct 10, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remove should be in an AfterEach or the finally or a try{}finally{} otherwise it won't run if the test fails. Might be easier to just use the test drive...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 10, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted a PR to resolve this: Indhukrishna#2 . I'll merge it if the tests pass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          convert test to use testdrive for automatic cleanup

24c1c87

Travis Plunk (TravisEz13) dismissed their stale review

October 10, 2017 22:58

issues resolved

Travis Plunk (TravisEz13) approved these changes

Oct 10, 2017

View reviewed changes

Travis Plunk (TravisEz13) merged commit 2a9cd72 into PowerShell:master

Oct 11, 2017

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Add tests for Dsc configuration compilation on Windows (PowerShell#5011)

eb9c471

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Travis Plunk (TravisEz13)

Labels

Area-DSC

Desired State Configuration issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 4, 2017

Uh oh!

Arie Heinrich (ArieHein) commented Oct 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Indhu Sivaramakrishnan (Indhukrishna) commented Oct 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Arie Heinrich (ArieHein) commented Oct 8, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) Oct 10, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) Oct 10, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.