GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — SetServiceCommand: Add positional parameter attribute by travisty- · Pull Request #5017 · PowerShell/PowerShell

Conversation

@travisty-

@travisty- Travis Kinney (travisty-) commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.

Closes #4916.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@travisty-
SetServiceCommand: Add positional parameter attribute
6e76ad8 
Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.
@travisty-
Travis Kinney (travisty-) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners October 5, 2017 06:39
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Oct 6, 2017

Copy link
Copy Markdown
Member

Travis Kinney (@travisty-) Please add tests for the new scenario at: https://github.com/PowerShell/PowerShell/blob/master/test/powershell/Modules/Microsoft.PowerShell.Management/Set-Service.Tests.ps1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Oct 6, 2017
@travisty-

Travis Kinney (travisty-) commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

Hi Aditya Patwardhan (@adityapatwardhan) Dongbo Wang (@daxian-dbw), tests have been added for this scenario.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Oct 7, 2017

Copy link
Copy Markdown
Collaborator

Travis Kinney (@travisty-) Thanks for your contribution!

We should split formatting changes and code changes - this makes it easier to review and support code.
Please remove last commit and push only new test. We welcome improvements in formatting in a separate PR or commit.

Also if new test is under "Feature" CI tag please add [Feature] in header of your last commit to run the test in CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@travisty-
Add test for positional InputObjects [Feature]
04773a9 
Added a test to Set-Service validating InputObjects passed positionally.
@travisty-

Travis Kinney (travisty-) commented Oct 7, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback Ilya (@iSazonov). I'll submit the formatting improvements in a separate PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Oct 8, 2017
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 9, 2017
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 1d5c310 into PowerShell:master Oct 9, 2017
@travisty-
Travis Kinney (travisty-) deleted the feature/service-command-parameters branch October 9, 2017 17:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@travisty- @adityapatwardhan
SetServiceCommand: Add positional parameter attribute (PowerShell#5017)
e0a3d11 
* SetServiceCommand: Add positional parameter attribute

Added a positional parameter attribute to the InputObject parameter,
giving Set-Service behavior similar to the other *-Service cmdlets.

* Add test for positional InputObjects [Feature]

Added a test to Set-Service validating InputObjects passed positionally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@travisty- @msftclas @adityapatwardhan @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.