GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — treat .rtf files as binary so EOL don't get changed by SteveL-MSFT · Pull Request #5020 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Oct 5, 2017

Copy link
Copy Markdown
Member

with the change in .gitattributes, this file was being treated as text so git on Linux kept trying to autocorrect the EOL to LF (thus showing up as a modified file). Since this file is primarily used in our .msi pkg on Windows, we should retain CRLF EOL. updated .gitattributes to treat .rtf files as binary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Oct 5, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Travis Plunk (TravisEz13) October 5, 2017 16:58
@SteveL-MSFT
treat .rtf files as binary so EOL don't get changed
f2472a0
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the gitattributes branch from e921479 to f2472a0 Compare October 5, 2017 16:58
@SteveL-MSFT Steve Lee (SteveL-MSFT) mentioned this pull request Oct 5, 2017
Replace CRLF with LF for some files in assets #5025
Merged
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Oct 5, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit b7f3dfe into PowerShell:master Oct 5, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the gitattributes branch October 5, 2017 23:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @daxian-dbw
Treat .rtf files as binary so EOL don't get changed (PowerShell#5020)
c8aabc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @daxian-dbw @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.