GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Travis-CI macOS run by SteveL-MSFT · Pull Request #5065 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Oct 9, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixed some formatting and output issues. Main fix to get the build working is moving brew update earlier (thanks Travis Plunk (@TravisEz13)). Removed sudo check as it fails on Travis-CI

Fix #5062

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners October 9, 2017 16:39
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the macos-travis branch 2 times, most recently from 596eddf to 84ca934 Compare October 9, 2017 16:59
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title [Do not merge] get more output from brew update to see what problem is [Do not merge] Fix Travis-CI macOS run Oct 9, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the macos-travis branch 7 times, most recently from 4fb6091 to 8b86f5b Compare October 9, 2017 18:29
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title [Do not merge] Fix Travis-CI macOS run Fix Travis-CI macOS run Oct 9, 2017
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Oct 9, 2017
@SteveL-MSFT
Fix some output strings
b59953e 
Commented out check for sudo as it was failing on Travis-CI
Updated version of Ruby to 2.3.3
Reorder install so Ruby gets installed before installing PS as Homebrew relies on Ruby 2.3
Remove sudo check which breaks Travis-CI
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the macos-travis branch from 8b86f5b to b59953e Compare October 9, 2017 18:55
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Oct 9, 2017
Update script to get PSVersion from $PSVersionTable #5045
Merged
TravisEz13
Travis Plunk (TravisEz13) reviewed Oct 9, 2017
View reviewed changes
Comment thread tools/installpsh-osx.sh
exit 5
fi
fi
#if [[ "$SUDO" -eq "sudo" ]]; then

@TravisEz13 Travis Plunk (TravisEz13) Oct 9, 2017 •
edited by SteveL-MSFT
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this commented code if it's not needed. Perhaps we can wait until someone complains before making further changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Oct 9, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me if this is needed for local execution of this script or if anyone actually uses these scripts locally outside of CI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 9, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 9d5823b into PowerShell:master Oct 9, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the macos-travis branch October 9, 2017 20:37
Michal Čihař (nijel) added a commit to phpmyadmin/phpmyadmin that referenced this pull request Oct 10, 2017
@nijel
Use newer ruby
b97fa54 
Based on PowerShell/PowerShell#5065

Signed-off-by: Michal Čihař <[email protected]>
@benapetr Petr Bena (benapetr) mentioned this pull request Oct 10, 2017
Travis CI macOS Builds are failing #5062
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
Fix some output strings (PowerShell#5065)
e28b647 
Commented out check for sudo as it was failing on Travis-CI
Updated version of Ruby to 2.3.3
Reorder install so Ruby gets installed before installing PS as Homebrew relies on Ruby 2.3
Remove sudo check which breaks Travis-CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Travis CI macOS Builds are failing

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@SteveL-MSFT @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.