GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove dead code by lzybkr · Pull Request #5066 · PowerShell/PowerShell

Conversation

@lzybkr

@lzybkr Jason Shirk (lzybkr) commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

Code guarded by the following defines is ancient and has never been
used, so removing.

  • RELATIONSHIP_SUPPORTED
  • SUPPORTS_IMULTIVALUEPROPERTYCMDLETPROVIDER

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lzybkr
Jason Shirk (lzybkr) requested review from Bruce Payette (BrucePay), Steve Lee (SteveL-MSFT) and Dongbo Wang (daxian-dbw) October 9, 2017 20:36
@lzybkr
Jason Shirk (lzybkr) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and sergei (vors) as code owners October 9, 2017 20:36
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 9, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 9, 2017

Copy link
Copy Markdown
Member

Jason Shirk (@lzybkr) are these used in Windows PowerShell (and thus a breaking change)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anmenaga

Andrew (anmenaga) commented Oct 9, 2017

Copy link
Copy Markdown

Steve Lee (@SteveL-MSFT) I've ran a search on WindowsPS code; I don't see these macros defined anywhere.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lzybkr
Remove dead code
e48199e 
Code guarded by the following defines is ancient and has never been
used, so removing.

* RELATIONSHIP_SUPPORTED
* SUPPORTS_IMULTIVALUEPROPERTYCMDLETPROVIDER
* SUPPORTS_CMDLETPROVIDER_FILE

Also removed some unused platform dependent unsafe code.
@lzybkr

Jason Shirk (lzybkr) commented Oct 9, 2017

Copy link
Copy Markdown
Contributor Author

Right, this code has never been used, probably hasn't been compiled in over 10 years.
I pushed a couple more changes (sorry, force pushed) to remove a little bit more unused dead code (well, the file I removed is probably being compiled, but not used apparently, removed because I saw #if IA64 and was going to kill that, realized I'd never seen that code before, and did a build without it.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Oct 9, 2017

Copy link
Copy Markdown
Member

A side question, the PSMI code at https://github.com/PowerShell/PowerShell/tree/master/src/System.Management.Automation/engine/PSMI is the prototype code Indhu Sivaramakrishnan (@Indhukrishna) worked on about 4 years ago to do powershell remoting over WMI remoting. Do we still need that code?

Indhu Sivaramakrishnan (@Indhukrishna) can you please weigh in?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Oct 9, 2017
View reviewed changes
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Oct 10, 2017

Copy link
Copy Markdown
Member

I synced with Indhu Sivaramakrishnan (@Indhukrishna) offline and submitted PR #5075 to remove PSMI code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Oct 10, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 22662c8 into PowerShell:master Oct 10, 2017
@lzybkr
Jason Shirk (lzybkr) deleted the remove_ancient_dead_code branch October 10, 2017 16:59
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@lzybkr @daxian-dbw
Remove dead code (PowerShell#5066)
3f03064 
Code guarded by the following defines is ancient and has never been
used, so removing.
* RELATIONSHIP_SUPPORTED
* SUPPORTS_IMULTIVALUEPROPERTYCMDLETPROVIDER
* SUPPORTS_CMDLETPROVIDER_FILE
Also removed some unused platform dependent unsafe code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@vors sergei (vors) Awaiting requested review from vors

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lzybkr @SteveL-MSFT @anmenaga @daxian-dbw @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.