GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — StopJobCommand: Remove Unreachable Code by travisty- · Pull Request #5091 · PowerShell/PowerShell

Conversation

@travisty-

@travisty- Travis Kinney (travisty-) commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

This code will never get executed, and its logic is
duplicated in the HandleStopJobCompleted() method.

Closes #1696.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@travisty-
StopJobCommand: Remove duplicate code
185b8a9 
This code will never get executed, and its logic is
duplicated in the HandleStopJobCompleted() method.
@travisty-
Travis Kinney (travisty-) requested review from Paul Higinbotham (PaulHigin), Dan Travison (dantraMSFT) and Mike Richmond (mirichmo) as code owners October 12, 2017 06:32
@travisty- Travis Kinney (travisty-) mentioned this pull request Oct 12, 2017
Remove dead code in StopJob.cs (line 164) #1696
Closed
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Oct 12, 2017
View reviewed changes
PaulHigin
Paul Higinbotham (PaulHigin) approved these changes Oct 13, 2017
View reviewed changes

@PaulHigin Paul Higinbotham (PaulHigin) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mirichmo Mike Richmond (mirichmo) self-assigned this Oct 13, 2017
mirichmo
Mike Richmond (mirichmo) approved these changes Oct 13, 2017
View reviewed changes
@mirichmo

Mike Richmond (mirichmo) commented Oct 13, 2017

Copy link
Copy Markdown
Member

Thanks for the contribution Travis Kinney (@travisty-). I'll merge it once we get the tests to pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mirichmo Mike Richmond (mirichmo) changed the title StopJobCommand: Remove duplicate code StopJobCommand: Remove Unreachable Code Oct 13, 2017
@mirichmo
Mike Richmond (mirichmo) merged commit 52f9125 into PowerShell:master Oct 16, 2017
@travisty-
Travis Kinney (travisty-) deleted the cleanup/stop-job branch October 16, 2017 17:07
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@travisty- @mirichmo
StopJobCommand: Remove Unreachable Code (PowerShell#5091)
2dcd967 
This code will never get executed, and its logic is
duplicated in the HandleStopJobCompleted() method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
@mirichmo Mike Richmond (mirichmo) mirichmo approved these changes
@PaulHigin Paul Higinbotham (PaulHigin) PaulHigin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@travisty- @mirichmo @dantraMSFT @PaulHigin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.