GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — update docker file for nanoserver 1709 release by TravisEz13 · Pull Request #5252 · PowerShell/PowerShell

Conversation

Travis Plunk (TravisEz13) commented Oct 27, 2017

Copy link

Copy Markdown

Member

merge nanoserver-insider image into main nanoserver docker file
add argument validation
fix minor issues

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) added 3 commits

October 26, 2017 10:37


          Merge nanoserver-insider to nanoserver as it has released

c360d3c


          Add Arg Validation

84298b7


          update windows server core to use latest image

24a8a71

Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners

October 27, 2017 04:36

Aditya Patwardhan (adityapatwardhan) approved these changes

Oct 27, 2017

View reviewed changes

Mike Richmond (mirichmo) reviewed

Oct 27, 2017

View reviewed changes

Comment thread

docker/release/nanoserver/Dockerfile

		Throw [String]$('['+$PSVersionTable.PSEdition+'] is not [Core]!') ; `
		} ;
		# Copy Powershell Core from the installer containter
		ENV ProgramFiles C:\Program Files

Mike Richmond (mirichmo) Oct 27, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are quotes needed here around c:\Program Files? A bigger question that I don't quite understand: Why are you defining it here and not using $env:ProgramFiles or %ProgramFiles%?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 27, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a tested an working file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 27, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only two changes to the file. I added comments for the two changes. The file which was deleted, otherwise replaced the older file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mike Richmond (mirichmo) Oct 27, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about my second question? I added it a little later via edit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Oct 27, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker itself cannot use the container environment variables. This is used in docker commands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) commented

Oct 27, 2017

View reviewed changes

Comment thread

docker/release/nanoserver/Dockerfile


		SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]

		RUN if (!($env:PS_VERSION -match '^\d+\.\d+\.\d+(-\w+\.\d+)?$' )) {throw ('PS_Version ({0}) must match the regex "^\d+\.\d+\.\d+(-\w+\.\d+)?$"' -f $env:PS_VERSION)}

Travis Plunk (TravisEz13) Oct 27, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was added

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) commented

Oct 27, 2017

View reviewed changes

Comment thread

docker/release/nanoserver/Dockerfile

		# escape=`
		FROM microsoft/nanoserver:latest
		# Args used by from statements must be defined here:
		ARG NanoServerVersion=1709

Travis Plunk (TravisEz13) Oct 27, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the values for these first arguments changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Mike Richmond (mirichmo) approved these changes

Oct 27, 2017

View reviewed changes

Travis Plunk (TravisEz13) merged commit 14af3e1 into PowerShell:master

Oct 27, 2017

Travis Plunk (TravisEz13) deleted the nanoserverUpdate branch

October 27, 2017 18:57

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          update docker file for nanoserver 1709 release (PowerShell#5252)

4313e1f

Reviewers

Aditya Patwardhan (adityapatwardhan)

adityapatwardhan approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

+1 more reviewer

Mike Richmond (mirichmo)

mirichmo approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Travis Plunk (TravisEz13) commented Oct 27, 2017

Uh oh!

Mike Richmond (mirichmo) Oct 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Mike Richmond (mirichmo) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mike Richmond (mirichmo) Oct 27, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.