GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Porting random hang fixes by PaulHigin · Pull Request #5258 · PowerShell/PowerShell

Conversation

@PaulHigin

@PaulHigin Paul Higinbotham (PaulHigin) commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

These are two fixes for random hangs found internally.

The first fix (job.cs) is for data stream Close calls on PSDataCollection objects because the method also raises public events. If an exception is thrown on the event handler then the thread never completes job clean up causing a hang. Fix is to catch all thrown exceptions and report.

The second (invokecommandcommand.cs) fixes a hang scenario where a remote job goes into disconnected state while simultaneously handling an exception. Fix is to use try/finally pattern to ensure Invoke-Command can always complete with jobs in the disconnected state.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@PaulHigin
Porting random hang fixes
50c51e5
@PaulHigin Paul Higinbotham (PaulHigin) added the WG-Remoting PSRP issues with any transport layer label Oct 27, 2017
@PaulHigin Paul Higinbotham (PaulHigin) assigned Aditya Patwardhan (adityapatwardhan) Oct 27, 2017
@PaulHigin
Paul Higinbotham (PaulHigin) requested review from Dan Travison (dantraMSFT) and Mike Richmond (mirichmo) as code owners October 27, 2017 17:29
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Oct 30, 2017
View reviewed changes
@PaulHigin
Paul Higinbotham (PaulHigin) removed the request for review from Mike Richmond (mirichmo) October 31, 2017 15:28
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 6, 2017

Copy link
Copy Markdown
Member

Paul Higinbotham (@PaulHigin) Is it possible to add tests for this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PaulHigin

Paul Higinbotham (PaulHigin) commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) No, not safely. The code closes all opened runspaces when an "interactive host" runspaces closes, which unfortunately includes Pester runspaces.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PaulHigin

Paul Higinbotham (PaulHigin) commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) Whoops, I though this was referring to the recent PowerShell hang on exit issue. But again, the answer is not to tests since this is fixing rare random hangs. I might be able to add test hooks, but I don't know if it is worth it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 6, 2017

Copy link
Copy Markdown
Member

We should just take this PR into account when we develop reliability specific tests as part of #4008

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 73188ce into PowerShell:master Nov 10, 2017
@PaulHigin
Paul Higinbotham (PaulHigin) deleted the port-hang-fixes branch January 23, 2018 16:46
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@PaulHigin @adityapatwardhan
Porting random hang fixes (PowerShell#5258)
3c231a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

WG-Remoting PSRP issues with any transport layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PaulHigin @adityapatwardhan @SteveL-MSFT @dantraMSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.