GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add documentation about how to create libpsl and psrp.windows packages by daxian-dbw · Pull Request #5278 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Oct 31, 2017

Copy link
Copy Markdown
Member

Related to #5231

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Dongbo Wang (daxian-dbw) added 2 commits October 30, 2017 17:51
@daxian-dbw
Add document about creating libpsl and psrp.windows nuget packages
201dff9
@daxian-dbw
Fix spelling
734bc71
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Oct 31, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) October 31, 2017 01:08
@daxian-dbw
Minor update
43b0e70
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Oct 31, 2017

Copy link
Copy Markdown
Member Author

NPM is checking Gulp is installed. This may take a few moments.
[-] Should not have errors in any markdown files 20.81s
Expected string length 9 but was 287. Strings differ at index 0.
Expected: {--EMPTY--}
But was: {C:\projects\powershell\docs\building\internals.md: 48: MD007 Unordered list indentation C:\projects\powershell\docs\building\internals.md: 50: MD007 Unordered list indentation (See https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md for an explanation of the error codes)}

Travis Plunk (@TravisEz13) Can you please help with the failed markdown test? Error code MD007 means the unordered list doesn't use 2-space indentation. However, line 48 and 50 both use 2 space indentation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Fix markdown test failure
0560c8f
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Oct 31, 2017
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) reviewed Nov 1, 2017
View reviewed changes
Comment thread test/common/markdown/markdown.tests.ps1
$docsToTest = @(
'./*.md'
'./docs/*.md'
'./docs/building/*.md'

@TravisEz13 Travis Plunk (TravisEz13) Nov 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 1, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 532044f into PowerShell:master Nov 1, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the docs branch November 1, 2017 22:55
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Add documentation about how to create libpsl and psrp.windows packages (
f79b22c 
PowerShell#5278)

- Add document about creating libpsl and psrp.windows nuget packages
- Clean up and update the existing building docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @TravisEz13 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.