GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Always run test with crossgen'ed assemblies in CI by daxian-dbw · Pull Request #5315 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Nov 2, 2017

Copy link
Copy Markdown
Member

The crossgen issue dotnet/coreclr#9745 that causes parser test to hang has been fixed in 2.0.4-servicing preview packages, and we have updated powershell project files to build against that runtime (see PR #5295). So now we need to revert the previous workaround in our CI/test scripts, so that we always run crossgen in our CI build and run tests with the crossgen'ed assemblies.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
[Feature] Always run test with crossgen'ed assemblies in CI
19368d0
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Nov 2, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) November 2, 2017 21:29
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Travis Plunk (TravisEz13) as a code owner November 2, 2017 21:29
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 2, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 3771c88 into PowerShell:master Nov 3, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the crossgenhang branch November 3, 2017 01:03
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Always run test with crossgen'ed assemblies in CI (PowerShell#5315)
fadf61f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @TravisEz13 @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.