GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add Uniform Type Identifier to osxpkg by SteveL-MSFT · Pull Request #5323 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Nov 3, 2017

Copy link
Copy Markdown
Member

Use standard reverse dns format for UTI prefix: com.microsoft

Fix #5103

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
add Uniform Type Identifier conforming with Apple standards using a r…
fd6c70e 
…everse dns style prefix
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Nov 3, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Travis Plunk (TravisEz13) November 3, 2017 05:21
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 3, 2017 05:21
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 3, 2017

Copy link
Copy Markdown
Member

Greg Zimmerman (@thezim) Please review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 3, 2017
View reviewed changes
thezim
Greg Zimmerman (thezim) approved these changes Nov 4, 2017
View reviewed changes

@thezim Greg Zimmerman (thezim) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tools/packaging/packaging.psm1
$Arguments += @("--rpm-os", "linux")
}
if ($Environment.IsMacOS) {
$Arguments += @("--osxpkg-identifier-prefix", "com.microsoft")

@thezim Greg Zimmerman (thezim) Nov 4, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.microsoft.powershell to be in the launcher configuration as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@thezim Greg Zimmerman (thezim) Nov 4, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I forgot #5291 has not gone in yet.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thezim Greg Zimmerman (thezim) mentioned this pull request Nov 4, 2017
Enable macOS launcher #5291
Merged
@TravisEz13
Travis Plunk (TravisEz13) merged commit 0557f2d into PowerShell:master Nov 5, 2017
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 5, 2017

Copy link
Copy Markdown
Member

Greg Zimmerman (@thezim) Can you update your PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the mac-uti branch November 12, 2017 05:17
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
add Uniform Type Identifier conforming with Apple standards using a r…
e9b91ec 
…everse dns style prefix (PowerShell#5323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@thezim Greg Zimmerman (thezim) thezim approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define Uniform Type Identifier for macOS install package.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @TravisEz13 @thezim
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.