GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Wix toolset download link in error message to newer version 3.11 (same as CI) by bergmeister · Pull Request #5339 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Nov 4, 2017

Copy link
Copy Markdown
Contributor

This makes it also future proof because:

  • Codeplexx is going to get deprecated and the new link links directly to the GitHub repository.
  • Only version 3.11 enabled support for Visual Studio 2017.

I have tested locally (on a machine that does not have the old WiX v 3.10 but only the new version 3.11) that building the installer still works.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
Update Wix toolset download link to newer version 3.11
a998e8c 
This makes it also future proof since codeplexx is going to get deprecated.
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 4, 2017 17:06
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 4, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can someone test the package https://ci.appveyor.com/project/bergmeister/powershell/build/artifacts ~~

  • Windows 10
  • Windows 8.1
  • Windows 7 - x64
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Nov 4, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) This PR only changes the error message displayed to someone who tries to build PowerShell locally but does not have WiX installed (in fact the check is not against a specific version). Therefore it does not change the build itself, hence no need for testing.
In your appveyor.yml file here, the Visual Studio 2017 image is specified, which already has WiX Toolset 3.11.0.1701
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 5, 2017
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 5, 2017

Copy link
Copy Markdown
Member

Sorry, just going through a lot of PRs quickly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister Christoph Bergmeister (bergmeister) changed the title Update Wix toolset download link to newer version 3.11 Update Wix toolset download link in error message to newer version 3.11 (same as CI) Nov 5, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 6b700bb into PowerShell:master Nov 6, 2017
@iSazonov

Ilya (iSazonov) commented Jan 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Christoph Bergmeister (@bergmeister) Maybe replace the link with https://github.com/wixtoolset/wix3/releases/tag/wix3111rtm and suggest to install latest version ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Or just https://github.com/wixtoolset/wix3/releases to future proof it since WiX 4 is in a separate repo anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @daxian-dbw
Update Wix toolset download link to newer version 3.11 (PowerShell#5339)
352a1b5 
This makes it also future proof since codeplex is going to get deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bergmeister @TravisEz13 @iSazonov @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.