GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove PerformWSManPluginReportCompletion from pwrshplugin.dll by bergmeister · Pull Request #5498 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Nov 18, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This resolves issue #5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext , which is now unused as well.

The best reviewer is probably Mike Richmond (@mirichmo) , who raised the initial issue with very helpful descriptions or Dan Travison (@dantraMSFT) who is currently assigned to the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) added 2 commits November 18, 2017 10:04
@bergmeister
Remove PerformWSManPluginReportCompletion from pwrshplugin.dll to res…
c719263
…olve issue 5391
@bergmeister
Remove g_pPluginContext member, which is now unused as well and was o…
44c0c1e
…nly used for WSManPluginReportCompletion
@bergmeister Christoph Bergmeister (bergmeister) closed this Nov 20, 2017
@bergmeister Christoph Bergmeister (bergmeister) reopened this Nov 20, 2017
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Nov 27, 2017
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-GA milestone Nov 27, 2017
@dantraMSFT
Dan Travison (dantraMSFT) self-requested a review November 28, 2017 18:54
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Nov 28, 2017
View reviewed changes

@dantraMSFT Dan Travison (dantraMSFT) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@TravisEz13
Travis Plunk (TravisEz13) merged commit cc0e74a into PowerShell:master Nov 28, 2017
@TravisEz13 Travis Plunk (TravisEz13) added the Compliance Related to compliance requirements label Nov 28, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 29, 2017
@bergmeister @TravisEz13
Remove PerformWSManPluginReportCompletion from pwrshplugin.dll (Power…
f98fa08
…Shell#5498)

This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well.

The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Nov 29, 2017
Merge 6.0.0 ga changes #5573
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Nov 29, 2017
@bergmeister @TravisEz13
Remove PerformWSManPluginReportCompletion from pwrshplugin.dll (#5498)
724095e
This resolves issue #5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well.

The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @TravisEz13
Remove PerformWSManPluginReportCompletion from pwrshplugin.dll (Power…
a29b9a3
…Shell#5498)

This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well.

The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @TravisEz13
Remove PerformWSManPluginReportCompletion from pwrshplugin.dll (Power…
fa11191
…Shell#5498)

This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well.

The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

Compliance Related to compliance requirements

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @dantraMSFT @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.