GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix docker tests by TravisEz13 · Pull Request #5508 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Nov 20, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • remove OpenSUSE and amazonlinux as they are not community images and not published.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 20, 2017 18:30
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Nov 20, 2017

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) Can you add in the description why openSUSE and AmazonLinux were removed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Nov 20, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aditya Patwardhan (@adityapatwardhan) AmazonLinux and openSUSE are removed because we don't publish docker images for these 2 distros for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Nov 20, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) I think we should always target the master branch, and cherrypick commits to 6.0.0 branch, right?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) changed the base branch from 6.0.0 to master November 21, 2017 00:04
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the fix_docker_tests branch from cacdb8d to 165b8a4 Compare November 21, 2017 00:05
Travis Plunk (TravisEz13) added 2 commits November 21, 2017 13:11
@TravisEz13
update expected version
12dc4e4
@TravisEz13
update container list
a1af5f0
@TravisEz13
Travis Plunk (TravisEz13) force-pushed the fix_docker_tests branch from 165b8a4 to a1af5f0 Compare November 21, 2017 21:11
@TravisEz13
Travis Plunk (TravisEz13) merged commit 227da48 into PowerShell:master Nov 21, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the fix_docker_tests branch November 21, 2017 21:52
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-GA milestone Nov 21, 2017
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 21, 2017

Copy link
Copy Markdown
Member Author

Marking for GA so we can test docker correctly for GA
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Nov 21, 2017
@TravisEz13
Fix docker tests (PowerShell#5508)
946339e 
* update expected version
* update container list
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Nov 21, 2017
Merge 6.0.0 GA changes #5522
Merged
Travis Plunk (TravisEz13) added a commit that referenced this pull request Nov 21, 2017
@TravisEz13
Fix docker tests (#5508)
4adaf73 
* update expected version
* update container list
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Fix docker tests (PowerShell#5508)
5f800a6 
* update expected version
* update container list
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Fix docker tests (PowerShell#5508)
3a7c2bc 
* update expected version
* update container list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@TravisEz13 @adityapatwardhan @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.