GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — move trust for ProductBinaries to Unrestricted. by TravisEz13 · Pull Request #5511 · PowerShell/PowerShell

Conversation

Travis Plunk (TravisEz13) commented Nov 20, 2017

Copy link

Copy Markdown

Member

fixes #5485

Causes Restricted and AllSigned execution policies to no longer trust PSHome by default.
To prevent behavior changes to Unrestricted, the trust for PShome was added here.
Update the description of Unrestricted to indicate that it requires the shell (an existing requirement.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) changed the base branch from 6.0.0 to master

November 21, 2017 00:03

Travis Plunk (TravisEz13) force-pushed the fix_allSigned branch from b5e8c7a to 662b32e Compare

November 21, 2017 00:04

Dongbo Wang (daxian-dbw) reviewed

Nov 21, 2017

View reviewed changes

Comment thread

src/System.Management.Automation/security/SecurityManager.cs Outdated

Dongbo Wang (daxian-dbw) Nov 21, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the execution policy is unrestricted, then I think we don't need this check anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) Nov 21, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with Travis offline. This check is needed to bypass files downloaded from the internet to $PSHome\Module when it's Unrestricted.
Need to add a comment about this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Dongbo Wang (daxian-dbw) approved these changes

Nov 21, 2017

View reviewed changes

Comment thread

src/System.Management.Automation/security/SecurityManager.cs Outdated

Dongbo Wang (daxian-dbw) Nov 21, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted with Travis offline. This check is needed to bypass files downloaded from the internet to $PSHome\Module when it's Unrestricted.
Need to add a comment about this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Steve Lee (SteveL-MSFT) commented Nov 21, 2017

Copy link

Copy Markdown

Member

Can we add a test?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) added 2 commits

November 21, 2017 13:13


          move trust for ProductBinaries to Unrestricted.

710b107


          address PR feedback

aea3299

Travis Plunk (TravisEz13) force-pushed the fix_allSigned branch from 7f2fe7b to 73c15ab Compare

November 27, 2017 21:19

Steve Lee (SteveL-MSFT) requested changes

Nov 27, 2017

View reviewed changes

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) Nov 27, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be $testData

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) Nov 27, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing param block

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) Nov 27, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to use ShouldBeErrorId?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Nov 28, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I accidentally pushed an incomplete commit. I have updated the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add tests

Travis Plunk (TravisEz13) force-pushed the fix_allSigned branch from cf20b34 to 3094513 Compare

November 28, 2017 01:23

Travis Plunk (TravisEz13) commented

Nov 28, 2017

View reviewed changes

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1

		}

		)
		foreach($testScript in $testScripts) {

Travis Plunk (TravisEz13) Nov 28, 2017

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, $testScripts was not defined in this scope, so nothing was being run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) commented Nov 28, 2017

Copy link

Copy Markdown

Member Author

Note, issue #5559 was filed when adding tests due to an issue with the tests. I have marked the affected tests to be skipped.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) requested changes

Nov 28, 2017

View reviewed changes

Comment thread

test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated

		error = $null
		}
		)
		It "$TestTypePrefix Running <testScript> Script should throw '<error>'" -TestCases $skipTestData -Skip {}

Steve Lee (SteveL-MSFT) Nov 28, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Pending and not Skipped?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          address PR feedback

Steve Lee (SteveL-MSFT) approved these changes

Nov 28, 2017

View reviewed changes

Travis Plunk (TravisEz13) assigned Dongbo Wang (daxian-dbw)

Nov 28, 2017

Travis Plunk (TravisEz13) added this to the 6.0.0-GA milestone

Nov 28, 2017

Dongbo Wang (daxian-dbw) merged commit f67844e into PowerShell:master

Nov 29, 2017

Travis Plunk (TravisEz13) deleted the fix_allSigned branch

November 29, 2017 01:56

Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request

Nov 30, 2017


          Make 'AllSigned' execution policy require modules under $PSHome to be…

7d06c7a

… signed (PowerShell#5511)

Travis Plunk (TravisEz13) mentioned this pull request

Nov 30, 2017

Merge 6.0.0 ga changes #5585

Merged

Travis Plunk (TravisEz13) added a commit that referenced this pull request

Nov 30, 2017


          Make 'AllSigned' execution policy require modules under $PSHome to be…

3f9ff3f

… signed (#5511)

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Make 'AllSigned' execution policy require modules under $PSHome to be…

5b779ac

… signed (PowerShell#5511)

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Make 'AllSigned' execution policy require modules under $PSHome to be…

ea00421

… signed (PowerShell#5511)

Reviewers

Dongbo Wang (daxian-dbw)

daxian-dbw approved these changes

Steve Lee (SteveL-MSFT)

SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

unsigned modules should not load with AllSigned policy

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

Travis Plunk (TravisEz13) commented Nov 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dongbo Wang (daxian-dbw) Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Nov 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dongbo Wang (daxian-dbw) Nov 21, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Dongbo Wang (daxian-dbw) Nov 21, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.