GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Import-CliXml Test by markekraus · Pull Request #5521 · PowerShell/PowerShell

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Nov 21, 2017

Copy link
Copy Markdown
Contributor

I noticed that there was an error in the Import-CliXml context but no failed tests. It turns out this was working because it was exporting null and then checking if null is null.. 🙁

This fixes the error generated by get-process and ensure the imported values are not null or empty.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@markekraus
Fix Import-CliXml Tests
bb1449e
@markekraus Mark Kraus (markekraus) changed the title Fix Import-CliXml Tests Fix Import-CliXml Test Nov 21, 2017
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Nov 21, 2017
View reviewed changes
@iSazonov Ilya (iSazonov) self-assigned this Nov 22, 2017
@iSazonov
Ilya (iSazonov) merged commit 7778941 into PowerShell:master Nov 22, 2017
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-GA milestone Nov 29, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 29, 2017
@markekraus @TravisEz13
Fix Import-CliXml Tests (PowerShell#5521)
a1be863 
Add checks that ProcessName is not null or empty.
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Nov 29, 2017
Merge 6.0.0 ga changes #5573
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Nov 29, 2017
@markekraus @TravisEz13
Fix Import-CliXml Tests (#5521)
2689338 
Add checks that ProcessName is not null or empty.
@markekraus
Mark Kraus (markekraus) deleted the FixImportCliXmlTest branch January 19, 2018 18:58
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @iSazonov
Fix Import-CliXml Tests (PowerShell#5521)
0a848c7 
Add checks that ProcessName is not null or empty.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @TravisEz13
Fix Import-CliXml Tests (PowerShell#5521)
ab72022 
Add checks that ProcessName is not null or empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markekraus @SteveL-MSFT @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.