GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: Enable building for win-arm and win-arm64 by SteveL-MSFT · Pull Request #5524 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Nov 22, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Requires VS2017 latest preview to build for arm64. Validated win-arm build on Win10 IOT with remoting, but current install script doesn't work correctly on Win10 IOT, need to update.

Also fixed issue with pwrshplugin.dll not validating path before using them.

Fix #5286

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) added this to the 6.0.0-GA milestone Nov 22, 2017
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Aditya Patwardhan (adityapatwardhan) Nov 22, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Aditya Patwardhan (adityapatwardhan) November 22, 2017 01:02
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) as code owners November 22, 2017 01:02
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 22, 2017

Copy link
Copy Markdown
Member Author

Waiting on mmi.dll to be published for win-arm and win-arm64
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 27, 2017

Copy link
Copy Markdown
Member Author

Confirmed that basic PSCore6 works on win-arm, I think we can merge this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Nov 28, 2017
View reviewed changes
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Nov 28, 2017

Copy link
Copy Markdown
Member Author

Aditya Patwardhan (@adityapatwardhan) hold off on merging this, looks like I need to build pwshplugin.dll for arm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Nov 28, 2017
View reviewed changes
Comment thread build.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Nov 28, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!$env:PROCESSOR_ARCHITECTURE -match "arm"

!$env:PROCESSOR_ARCHITECTURE will be evaluated first in this case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Nov 29, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Nov 28, 2017

Copy link
Copy Markdown
Member

Once the changes to building pwshplugin.dll is done, the psrp.windows package needs to be updated, and make sure the arm version plugin dll is signed before creating a new nuget package.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 4, 2017

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) please update here when psrp.windows package is updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 5, 2017

Copy link
Copy Markdown
Member

Note that PR #5617 would also require psrp.windows nuget package to be refreshed, so it's better to coordinate them to avoid duplicate work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
enable win-arm and win-arm64 builds
2db001b
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from 5acc38e to 2db001b Compare December 5, 2017 23:56
@SteveL-MSFT
address PR feedback
80aa7cd
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title enable building for win-arm and win-arm64 [Don't Merge] enable building for win-arm and win-arm64 Dec 6, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 6, 2017

Copy link
Copy Markdown
Member Author

Have some paths hardcoded to validate build. Will update, but requires user to have VS2017 latest installed to build for win-arm.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from 9c0d641 to 730336b Compare December 6, 2017 03:38
@SteveL-MSFT
fix using arm64 tools for build
384e38b 
fix finding vs2017 dynamically
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from 730336b to 384e38b Compare December 6, 2017 05:44
@SteveL-MSFT Steve Lee (SteveL-MSFT) changed the title [Don't Merge] enable building for win-arm and win-arm64 Enable building for win-arm and win-arm64 Dec 6, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 6, 2017

Copy link
Copy Markdown
Member Author

Verified pwrshplugin.dll works on both arm and arm64. Aditya Patwardhan (@adityapatwardhan) can you re-review this PR as I've made substantial changes for the native compilation?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
change install-powershellremoting.ps1 script to use reg provider rath…
28a9d8a 
…er than reg.exe so that error doesn't show on success

fix formatting issue in cmake.defs
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from 8f19ae4 to 28a9d8a Compare December 6, 2017 20:26
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 6, 2017
View reviewed changes

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/powershell-native/Install-PowerShellRemoting.ps1 Outdated

# Clean up
Remove-Item .\$fileName
New-Item $regKey -Force

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Dec 6, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New-Item $regKey -Force > $null

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 6, 2017

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) Can you have a look too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Mike Richmond (mirichmo) December 7, 2017 01:26
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 7, 2017

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) Yes, will look tonight or first thing tomorrow morning.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Dec 7, 2017
View reviewed changes
Comment thread build.psm1 Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Steve Lee (@SteveL-MSFT) Is it going to be required to use VS2017 to build the plugin dll?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) The build worker image we use in AppVeyor is Visual Studio 2015. Do we need to update that?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we are using Visual Studio 2017 through the AppVeyor.yml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't build the native binaries in CI, so it shouldn't matter. Maybe we should switch to an image that doesn't have VS pre-installed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) VS2017 is required to build arm64

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 7, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a question comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 7, 2017
View reviewed changes
Comment thread build.psm1 Outdated

@TravisEz13 Travis Plunk (TravisEz13) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x64_arm and x64_arm64 seems weird to me. Why are we combining two architectures?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 7, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment. This is the form that the Visual Studio build environment expects for cross compilation. The first is the host and the second the target. VS supports x86_arm64, for example which I'm not supporting here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve Lee (@SteveL-MSFT) Can you comment?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from 5540bb7 to e0e5a02 Compare December 7, 2017 21:25
@SteveL-MSFT
add check that path being read from config file is valid
34aa98b 
address PR feedback
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the win-arm branch from e0e5a02 to 34aa98b Compare December 7, 2017 22:13
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

Travis Plunk (@TravisEz13) Dongbo Wang (@daxian-dbw) Aditya Patwardhan (@adityapatwardhan) please review the change to the pwrshplugin config reader to address #5286

Decided to do that as part of this PR since I'm publishing a new drop to myget might as well do it once rather than twice.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 7, 2017

Copy link
Copy Markdown
Member Author

Published https://powershell.myget.org/feed/powershell-core/package/nuget/psrp.windows/6.0.0-rc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT Steve Lee (SteveL-MSFT) modified the milestones: 6.0.0-GA, 6.0.0-RC.2 Dec 7, 2017
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Dec 7, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/powershell-native/nativemsh/pwrshcommon/ConfigFileReader.cpp Outdated
if (*slashIter != L'\\')
CloseHandle(dirHandle);
this->pathToPowerShellAssemblies = psHomeDir;
if (this->pathToPowerShellAssemblies.size() > 0) // Found a match

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 7, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the size() > 0 check should be moved to before the CreateFileW call.
Or maybe the size() > 0 is not needed, because if getValueFromLine returns an empty string, I think CreateFileW will fail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 8, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote a small program to test this and an empty string does return an invalid handle. I can remove the size check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/powershell-native/nativemsh/pwrshcommon/ConfigFileReader.cpp Outdated
slashIter--;
if (*slashIter != L'\\')
CloseHandle(dirHandle);
this->coreClrDirectory = this->getValueFromLine(line, coreClrDirTag);

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why calling this->getValueFromLine(line, coreClrDirTag); again instead of use coreClrDir?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 8, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake, should have been coreClrDir. Will fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/powershell-native/nativemsh/pwrshcommon/ConfigFileReader.cpp Outdated
if (*slashIter != L'\\')
CloseHandle(dirHandle);
this->coreClrDirectory = this->getValueFromLine(line, coreClrDirTag);
if (this->coreClrDirectory.size() > 0) // Found a match

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 7, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about the size() check here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 8, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mirichmo
Mike Richmond (mirichmo) approved these changes Dec 8, 2017
View reviewed changes
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 8, 2017

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Making those changes means we need to create a new psrp.windows package. But that work doesn't block merging this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
fix copying of PowerShell.Core.Instrumentation as VS2017 puts it in $…
542ef66 
…HOME/source

address PR feedback
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 8, 2017

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) yeah, I realize that. After this is merged, I'll create one called RC2.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 8, 2017
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 8, 2017

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) Travis Plunk (@TravisEz13) Any ideas why WIP might be blocking this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Dec 8, 2017

Copy link
Copy Markdown
Member

it hasn't run, edit the title and it will run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) changed the title Enable building for win-arm and win-arm64 build: Enable building for win-arm and win-arm64 Dec 8, 2017
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit eb25428 into PowerShell:master Dec 8, 2017
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) mentioned this pull request Dec 9, 2017
Refresh the release for psrp.windows #5657
Closed
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the win-arm branch December 9, 2017 01:43
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 9, 2017
@SteveL-MSFT @TravisEz13
build: Enable building for win-arm and win-arm64 (PowerShell#5524)
a76ba75 
* enable win-arm and win-arm64 builds

* fix using arm64 tools for build
fix finding vs2017 dynamically

* change install-powershellremoting.ps1 script to use reg provider rather than reg.exe so that error doesn't show on success
fix formatting issue in cmake.defs

* add check that path being read from config file is valid
address PR feedback

* fix copying of PowerShell.Core.Instrumentation as VS2017 puts it in $HOME/source
address PR feedback
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 9, 2017
Move 6.0.0 rc.2 changes #5663
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 10, 2017
@SteveL-MSFT @TravisEz13
build: Enable building for win-arm and win-arm64 (#5524)
e2dc0ea 
* enable win-arm and win-arm64 builds

* fix using arm64 tools for build
fix finding vs2017 dynamically

* change install-powershellremoting.ps1 script to use reg provider rather than reg.exe so that error doesn't show on success
fix formatting issue in cmake.defs

* add check that path being read from config file is valid
address PR feedback

* fix copying of PowerShell.Core.Instrumentation as VS2017 puts it in $HOME/source
address PR feedback
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @adityapatwardhan
build: Enable building for win-arm and win-arm64 (PowerShell#5524)
fa50b7a 
* enable win-arm and win-arm64 builds

* fix using arm64 tools for build
fix finding vs2017 dynamically

* change install-powershellremoting.ps1 script to use reg provider rather than reg.exe so that error doesn't show on success
fix formatting issue in cmake.defs

* add check that path being read from config file is valid
address PR feedback

* fix copying of PowerShell.Core.Instrumentation as VS2017 puts it in $HOME/source
address PR feedback
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
build: Enable building for win-arm and win-arm64 (PowerShell#5524)
87084bb 
* enable win-arm and win-arm64 builds

* fix using arm64 tools for build
fix finding vs2017 dynamically

* change install-powershellremoting.ps1 script to use reg provider rather than reg.exe so that error doesn't show on success
fix formatting issue in cmake.defs

* add check that path being read from config file is valid
address PR feedback

* fix copying of PowerShell.Core.Instrumentation as VS2017 puts it in $HOME/source
address PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
+1 more reviewer
@mirichmo Mike Richmond (mirichmo) mirichmo approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Pwrshplugin Config File Paths Should be Validated Before Use

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@SteveL-MSFT @daxian-dbw @adityapatwardhan @TravisEz13 @mirichmo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.