GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — remove `signed` folder in zip after copying signed binaries for packaging by SteveL-MSFT · Pull Request #5527 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Nov 22, 2017

Copy link
Copy Markdown
Member

It appears that signing puts the signed binaries in a folder called signed. The current packaging copies the signed binaries over the unsigned binaries, but the signed folder is a child folder of the unsigned binaries so it gets added to the zip resulting in duplicate files that aren't used. Fix is to remove the signed folder after copying the signed binaries.

Fix #5506

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
remove signed folder in zip
05b026e
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Travis Plunk (TravisEz13) Nov 22, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Travis Plunk (TravisEz13) November 22, 2017 17:05
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners November 22, 2017 17:05
@SteveL-MSFT Steve Lee (SteveL-MSFT) added this to the 6.0.0-GA milestone Nov 22, 2017
bergmeister
Christoph Bergmeister (bergmeister) reviewed Nov 22, 2017
View reviewed changes
Comment thread tools/packaging/packaging.psm1

# Remove `signed` folder in buildpath now that signed binaries are copied
if (Test-Path $BuildPath\signed)
{

@bergmeister Christoph Bergmeister (bergmeister) Nov 22, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the brace on the same line as this seems to be the most common style? I have opened PR #5529 to help with the style in the future.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Nov 22, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed both styles in this file, but it seems that for if statements, at least near the code I added, the braces were on a new line

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) approved these changes Nov 28, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit db0498d into PowerShell:master Nov 28, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the zip-dupes branch November 28, 2017 22:31
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 29, 2017
@SteveL-MSFT @TravisEz13
remove signed folder in zip during packaging (PowerShell#5527)
7194117
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Nov 29, 2017
Merge 6.0.0 ga changes #5573
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Nov 29, 2017
@SteveL-MSFT @TravisEz13
remove signed folder in zip during packaging (#5527)
aae076e
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
remove signed folder in zip during packaging (PowerShell#5527)
494f811
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
remove signed folder in zip during packaging (PowerShell#5527)
bc9fb67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+1 more reviewer
@bergmeister Christoph Bergmeister (bergmeister) bergmeister left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @bergmeister @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.