GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge changes from master to 6.0.0-rc.2 by TravisEz13 · Pull Request #5626 · PowerShell/PowerShell

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Dec 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Merge PRs to 6.0.0-rc.2:
#5592
#5540
#5601
#5605
#5591
#5619
#5286

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Mark Kraus (markekraus) and others added 7 commits December 4, 2017 16:20
@markekraus @TravisEz13
Fix Get-EnvironmentInformation IsCoreCLR logic (PowerShell#5592)
e71e062
* Fix Get-EnvironmentInformation IsCoreCLR logic
Replace $Runtime = [System.Runtime.InteropServices.RuntimeInformation]  and $OSPlatform = [System.Runtime.InteropServices.OSPlatform]  with ($PSVersionTable.ContainsKey("PSEdition") -and $PSVersionTable.PSEdition -eq "Core").
@markekraus @TravisEz13
Replace HttpListener Response Tests with WebListener (PowerShell#5540)
0c4f3be
* Add Response Controller

* [Feature] Replace HttpListener Response tests with WebListener
@daxian-dbw @TravisEz13
Add retry logic to prerequisite URL tests (PowerShell#5601)
c0d5d54
* Disable Requisiste URLs tests

* Add retry for the URL tests
@daxian-dbw @TravisEz13
[Feature] Make the -SslProtocol tests pending (PowerShell#5605)
03b6b9b
@daxian-dbw @TravisEz13
[Feature] Supress the expected errors from Select-Xml tests (PowerShe…
c25cb72
…ll#5591)
@JamesWTruher @TravisEz13
Run tests for Windows installer only on Windows (PowerShell#5619)
19e800b
@TravisEz13
contribution guidelines: change to say updating changelog is required (…
6b837ce
…PowerShell#5586)

- Update contribution guidelines to make updating the changelog required
- add a checklist to PR template

Comment by @SteveL-MSFT :
> Everyone should understand that we are always open to feedback and nothing is set in stone. Based on a team discussion, one of the biggest costs for a release is creating the ChangeLog hence updating this document to push it to the contributor most aware of why the changes are being made and ideally how it's useful to end users.
@TravisEz13
Travis Plunk (TravisEz13) requested review from Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw) as code owners December 5, 2017 00:25
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 5, 2017
View reviewed changes
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 5, 2017
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit 7cb76f5 into PowerShell:6.0.0 Dec 5, 2017
@TravisEz13
Travis Plunk (TravisEz13) deleted the merge_6.0.0-rc.2_changes branch December 5, 2017 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@TravisEz13 @daxian-dbw @adityapatwardhan @markekraus @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.