GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make the '-SslProtocol' tests pending by daxian-dbw · Pull Request #5605 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 1, 2017

Copy link
Copy Markdown
Member

Related to #5590

Make the -SslProtocol tests pending for now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Dec 1, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Mark Kraus (markekraus) December 1, 2017 23:56
markekraus
Mark Kraus (markekraus) suggested changes Dec 2, 2017
View reviewed changes

@markekraus Mark Kraus (markekraus) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covered IWR, but what about the IRM failing tests?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

@markekraus Mark Kraus (markekraus) Dec 2, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all very hard to read and follow what is doing what. If we are going to use a foreach anyway, we might as well have them structured like this:

$testCases1 = @( 
    @{Test = @{SslProtocol = 'Default'; ActualProtocol = 'Default'}; Pending = $false }
    @{Test = @{SslProtocol = 'Tls'; ActualProtocol = 'Tls'}; Pending = $false }
    @{Test = @{SslProtocol = 'Tls11'; ActualProtocol = 'Tls11'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls12'; ActualProtocol = 'Tls12'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls11, Tls12'; ActualProtocol = 'Tls12'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls11, Tls12'; ActualProtocol = 'Tls12'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls11, Tls12'; ActualProtocol = 'Tls11'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls11, Tls12'; ActualProtocol = 'Tls11'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls11'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls11, Tls12'; ActualProtocol = 'Tls'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls11'; ActualProtocol = 'Tls'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls'}; Pending = $IsMacOS }
    @{Test = @{SslProtocol = 'Tls, Tls12'; ActualProtocol = 'Tls12'}; Pending = -not $IsWindows }

)
foreach ($entry in $testCases1) {
    It "Verifies Invoke-WebRequest -SslProtocol <SslProtocol> works on <ActualProtocol>" -TestCases ($entry.test) -Pending:($entry.Pending) {
        param($SslProtocol, $ActualProtocol)
        $params = @{
            Uri = Get-WebListenerUrl -Test 'Get' -Https -SslProtocol $ActualProtocol
            SslProtocol = $SslProtocol
            SkipCertificateCheck = $true
        }
        $response = Invoke-WebRequest @params
        $result = $Response.Content | ConvertFrom-Json

        $result.headers.Host | Should Be $params.Uri.Authority
    }
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 2, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot the Invoke-RestMethod tests 😨 Will add soon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markekraus reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 2, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests are currently not run in macOS. I thought they didn't apply to macOS.
Mark a test pending means the test should pass but it doesn't, and thus need to be fixed.
Mark a test Skip means it doesn't apply to a platform, and it's expected that the test doesn't run on that platform.
Do you think all test cases should work on all platforms? Or some tests should be marked as -Skip on some platforms?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@markekraus Mark Kraus (markekraus) Dec 2, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally did the test this way because I was trying to avoid a forereach loop. at the time the logic was simpler.. but.. it continues to get more complex 😦 .

In a perfect world, these should all work on all platforms. CoreFX does not have a any of these issues we've run into here documented. by all Accounts macOS should support multiple protocols at once (either they need to document that it's not supported or this is an issue) , and that one that fails on Linux should work. I need to open issues with CoreFX, but... I have make simple C# repros and I haven't had the time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 2, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will update the change to mark the tests -Pending on the platforms they currently don't run.
Thanks Mark Kraus (@markekraus) !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TravisEz13 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Dec 2, 2017
Add retry logic to prerequisite URL tests #5601
Merged
markekraus
Mark Kraus (markekraus) approved these changes Dec 2, 2017
View reviewed changes

@markekraus Mark Kraus (markekraus) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My requested changes are not blocking.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

@markekraus Mark Kraus (markekraus) Dec 2, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to possible CoreFX issue, please? My own missing word it bugging me 😆

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 4, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for spotting it!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated

@markekraus Mark Kraus (markekraus) Dec 2, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, if you would be so kind.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 4, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@markekraus Mark Kraus (markekraus) mentioned this pull request Dec 3, 2017
Tests related to -SslProtocol in web cmdlets are failing on macOS daily runs #5590
Closed
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 4, 2017

Copy link
Copy Markdown
Member

Dongbo Wang (@daxian-dbw) please fix, merge conflict.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the disablessl branch from 59a800b to 51380b8 Compare December 4, 2017 18:22
@daxian-dbw
[Feature] Make the -SslProtocol tests pending
02ffdc9
@daxian-dbw
Dongbo Wang (daxian-dbw) force-pushed the disablessl branch from 51380b8 to 02ffdc9 Compare December 4, 2017 18:31
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 4, 2017
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit c6f27dc into PowerShell:master Dec 4, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the disablessl branch December 4, 2017 19:38
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-RC.2 milestone Dec 5, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 5, 2017
@daxian-dbw @TravisEz13
[Feature] Make the -SslProtocol tests pending (PowerShell#5605)
03b6b9b
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 5, 2017
Merge changes from master to 6.0.0-rc.2 #5626
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 5, 2017
@daxian-dbw @TravisEz13
[Feature] Make the -SslProtocol tests pending (#5605)
c3d9978
@markekraus Mark Kraus (markekraus) mentioned this pull request Dec 5, 2017
Make Travis CI use libcurl+openssl+gssapi for macOS #5629
Merged
8 tasks done
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
[Feature] Make the -SslProtocol tests pending (PowerShell#5605)
81f6fb9
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @TravisEz13
[Feature] Make the -SslProtocol tests pending (PowerShell#5605)
7d94806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+1 more reviewer
@markekraus Mark Kraus (markekraus) markekraus approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daxian-dbw @adityapatwardhan @markekraus @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.