GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor refactoring of the release build scripts by daxian-dbw · Pull Request #5632 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 5, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • [NA] Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [NA] Update the changelog -- -- This change doesn't need to go in ChangeLog.md, which the subsequent work to enable signing for win-arm and win-arm64 packages needs to.
  • [NA] User facing Documentation needed
    • [NA] Issue filed - Issue link:
  • Change is not breaking
  • [NA] Make sure you've added a new test, if existing tests do not effectively test the code changed
    • [NA] Add [feature] if the change is significant or affectes feature tests

PR Summary

Some name changes, comment updates, and random fixes.
This depends on PowerShell/PSRelease#28 to be merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Dongbo Wang (daxian-dbw) added 2 commits December 5, 2017 10:04
@daxian-dbw
Update release build
41be404
@daxian-dbw
Minor refactoring of the build script
4b5ba7e
@daxian-dbw Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Dec 5, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Travis Plunk (TravisEz13) and Aditya Patwardhan (adityapatwardhan) December 5, 2017 23:24
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Dec 5, 2017
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) reviewed Dec 5, 2017
View reviewed changes
Comment thread tools/releaseBuild/build.json Outdated
@@ -69,7 +69,7 @@
],
"DockerImageName": "ps-winsrvcore",
"BinaryBucket": "symbols",

@TravisEz13 Travis Plunk (TravisEz13) Dec 5, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we change the containerfolder in the other PR, we need to change the binarybucker where it equals symbols to results

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 6, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the other PR has been updated. I also changed BinaryBucket to results for the -symbols entries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Address comment
e04cdeb
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Dec 6, 2017

Copy link
Copy Markdown
Member

Travis Plunk (@TravisEz13) Can you have another look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 6, 2017
View reviewed changes
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 233f35f into PowerShell:master Dec 6, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 7, 2017
@daxian-dbw @TravisEz13
Minor refactoring of the release build scripts (PowerShell#5632)
a8e67eb 
* Update release build

* Minor refactoring of the build script
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the build branch December 7, 2017 02:12
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 7, 2017
Move 6.0.0 rc.2 changes #5646
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 7, 2017
@daxian-dbw @TravisEz13
Minor refactoring of the release build scripts (#5632)
237ac0b 
* Update release build

* Minor refactoring of the build script
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-RC.2 milestone Dec 8, 2017
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @adityapatwardhan
Minor refactoring of the release build scripts (PowerShell#5632)
3dfebbf 
* Update release build

* Minor refactoring of the build script
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @TravisEz13
Minor refactoring of the release build scripts (PowerShell#5632)
c9c2c97 
* Update release build

* Minor refactoring of the build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adityapatwardhan Aditya Patwardhan (adityapatwardhan)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@daxian-dbw @adityapatwardhan @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.