GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — updated doc to build arm/arm64 versions of psrp.windows library by SteveL-MSFT · Pull Request #5668 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Dec 11, 2017

Copy link
Copy Markdown
Member

PR Summary

The doc to build and publish psrp.windows library needed to be updated to support arm and arm64 builds. It was also missing steps for signing and publishing. Added details on individual features needed for VS2017 and location to publish on MyGet.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [NA] User facing Documentation needed
    • Issue filed - Issue link:
  • [NA] Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affectes feature tests
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
updated doc to build arm/arm64 versions of psrp.windows library
8e3a6d6
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw) Dec 11, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested a review from Dongbo Wang (daxian-dbw) December 11, 2017 18:57
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 11, 2017
View reviewed changes
Comment thread docs/building/internals.md Outdated
The `x64_arm` and `x64_arm64` architectures mean that the host system needs to be x64 to cross-compile to ARM.
When building for multiple architectures, be sure to use the `-clean` switch as cmake will cache the previous run and the wrong compiler will be used to generate the subsequent architecutes.

After that, the binary `pwrshplugin.dll` and its PDB file will be placed under 'src\powershell-native\bin\release\coreclr'.

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use the path 'src\powershell-win-core' here. The dll and pdb files will be bin-placed to "src\powershell-win-core" (see the script), and it's the same to 'PowerShell.Core.Instrumentation.dll' which will also be produced when running Start-BuildNativeWindowsBinaries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will change it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/building/internals.md Outdated
```

Lastly, run `nuget pack .` from within the folder. Note that you may need the latest `nuget.exe`.
Have the dlls signed and run `nuget pack` from the parent of the `runtimes` folder where `psrp.windows.nuspec` resides.

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the dlls signed

Please add "with authenticode dual certificate"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 11, 2017

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) I just released we don't have arm32/arm64 version of PowerShell.Core.Instrumentation.dll for the PowerShell.Core.Instrumentation nuget package ...

Can we build PowerShell.Core.Instrumentation.dll with x64_arm64 and x64_arm?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) I'll publish a new pkg for those dlls
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

I'll merge the psrp.windows and powershell.core.instrumentation sections into a general Windows native section
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
fix spelling
727832d 
address PR feedback
merge PowerShell.Core.Instrumentation section into PSRP.Windows section
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 11, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 78271eb into PowerShell:master Dec 11, 2017
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 11, 2017

Copy link
Copy Markdown
Member Author

Published https://powershell.myget.org/feed/powershell-core/package/nuget/PowerShell.Core.Instrumentation/6.0.0-RC2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the psrpwindows-doc branch December 11, 2017 22:50
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.0.0-RC.2 milestone Dec 12, 2017
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Dec 12, 2017
@SteveL-MSFT @daxian-dbw
Updated doc to build arm/arm64 versions of psrp.windows and PowerShel…
a52b010 
…l.Core.Instrumentation.dll libraries (#5668)
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Dec 12, 2017
Move 6.0.0 rc.2 changes #5671
Merged
5 of 7 tasks
Dongbo Wang (daxian-dbw) pushed a commit that referenced this pull request Dec 12, 2017
@SteveL-MSFT @daxian-dbw
Updated doc to build arm/arm64 versions of psrp.windows and PowerShel…
64647c2 
…l.Core.Instrumentation.dll libraries (#5668)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @daxian-dbw
Updated doc to build arm/arm64 versions of psrp.windows and PowerShel…
f160744 
…l.Core.Instrumentation.dll libraries (PowerShell#5668)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @daxian-dbw
Updated doc to build arm/arm64 versions of psrp.windows and PowerShel…
01e1296 
…l.Core.Instrumentation.dll libraries (PowerShell#5668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@SteveL-MSFT @daxian-dbw
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.