GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update PowerShell to build with .NET Core 2.0.4 by daxian-dbw · Pull Request #5677 · PowerShell/PowerShell

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Summary

Close #5428
Update PowerShell to build with .NET Core 2.0.4. (turn out to be a simple change 😄)

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [na] User facing Documentation needed
    • [na] Issue filed - Issue link:
  • Change is not breaking
  • [na] Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affectes feature tests
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
[Feature] Update PowerShell to build with .NET Core 2.0.4
e61e004
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Dec 12, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) December 12, 2017 18:58
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from Aditya Patwardhan (adityapatwardhan) as a code owner December 12, 2017 18:58
anmenaga
Andrew (anmenaga) approved these changes Dec 12, 2017
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) reviewed Dec 12, 2017
View reviewed changes
Comment thread PowerShell.Common.props
<Copyright>(c) Microsoft Corporation. All rights reserved.</Copyright>

<TargetFramework>netcoreapp2.0</TargetFramework>
<RuntimeFrameworkVersion>2.0.4-servicing-25831-01</RuntimeFrameworkVersion>

@TravisEz13 Travis Plunk (TravisEz13) Dec 12, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update the appveyor yml to flush the cache?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 12, 2017
View reviewed changes
@daxian-dbw
[Feature] Update appveyor.yml to flush the cache
22d2024
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 6.0.0-RC.2 milestone Dec 12, 2017
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 12, 2017

Copy link
Copy Markdown
Member Author

Investigating the xUnit test failures.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Dec 12, 2017
View reviewed changes
@rkeithhill

Keith Hill (rkeithhill) commented Dec 12, 2017

Copy link
Copy Markdown
Collaborator

Don't forget to update - https://github.com/PowerShell/PowerShell/blob/master/global.json
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 12, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Keith Hill (@rkeithhill) That is the SDK version. SDK version is not changed in this PR and we are still using 2.0.2. This PR only changes the version of .NET Core Runtime Framework that powershell targets.
rkeithhill reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rkeithhill

Keith Hill (rkeithhill) commented Dec 12, 2017

Copy link
Copy Markdown
Collaborator

I'm beginning to understand sergei (@vors) rant on Twitter about .NET Core versioning. :-)
SteveL-MSFT reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit d966f59 into PowerShell:master Dec 12, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the upgrade branch December 12, 2017 21:53
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 13, 2017
@daxian-dbw @TravisEz13
Update PowerShell to build with .NET Core runtime 2.0.4 (PowerShell#5677
7db6146 
)
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 13, 2017
merge 6.0.0 rc.2 changes2 #5680
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 13, 2017
@daxian-dbw @TravisEz13
Update PowerShell to build with .NET Core runtime 2.0.4 (#5677)
48961a5
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Update PowerShell to build with .NET Core runtime 2.0.4 (PowerShell#5677
ed0bfd0 
)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @TravisEz13
Update PowerShell to build with .NET Core runtime 2.0.4 (PowerShell#5677
241c1ef 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

6.0.0-RC.2

Development

Successfully merging this pull request may close these issues.

Use dotnetcore 2.0.4 final for GA

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@daxian-dbw @rkeithhill @TravisEz13 @SteveL-MSFT @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.