GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add instructions to deploy PSCore6 on Windows IoT arm32 by SteveL-MSFT · Pull Request #5682 · PowerShell/PowerShell

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Dec 13, 2017

Copy link
Copy Markdown
Member

PR Summary

Update README.md to include win-arm build and link to installation instructions. Add section to windows.md installation instructions specifically for Windows IoT. Added Experimental labels to win-arm and linux-arm packages since dotnetcore doesn't formally support them yet and we haven't fully tested them.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • [NA] User facing Documentation needed
    • Issue filed - Issue link:
  • Change is not breaking
  • [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affectes feature tests
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) added this to the 6.0.0-RC.2 milestone Dec 13, 2017
@SteveL-MSFT Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw) Dec 13, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw) December 13, 2017 03:40
anmenaga
Andrew (anmenaga) suggested changes Dec 13, 2017
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/installation/windows.md Outdated

@anmenaga Andrew (anmenaga) Dec 13, 2017

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Travis CI detected spelling error in this line about "PSSession".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 13, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 14, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSSession is a class name, so maybe we should put it in a code block (enclose it with ``). If so, we don't need to change the .spelling file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@SteveL-MSFT Steve Lee (SteveL-MSFT) Dec 14, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, will change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT Steve Lee (SteveL-MSFT) modified the milestones: 6.0.0-RC.2, 6.0.0-GA Dec 13, 2017
anmenaga
Andrew (anmenaga) approved these changes Dec 13, 2017
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daxian-dbw
Dongbo Wang (daxian-dbw) reviewed Dec 14, 2017
View reviewed changes
Comment thread README.md Outdated

@daxian-dbw Dongbo Wang (daxian-dbw) Dec 14, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis updated the readme.md to include win-arm32 and win-arm64 zip packages in #5688. Can you please review that and give your feedback?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Dec 14, 2017
Update scripts and documentation with RC.2 version #5688
Merged
5 tasks done
daxian-dbw
Dongbo Wang (daxian-dbw) previously requested changes Dec 14, 2017
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the install-winarm branch from aa2f73d to 7f1ecd6 Compare December 14, 2017 17:35
@daxian-dbw
Dongbo Wang (daxian-dbw) dismissed their stale review December 14, 2017 23:42

New commit has been pushed.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 14, 2017

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) Travis has incorporated your changes in README.md in his PR (which has been merged), so you can revert the changes in README.md.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
added instructions to deploy win-arm build on Windows IoT
7b2872e
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the install-winarm branch from 7f1ecd6 to 7b2872e Compare December 15, 2017 00:38
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Dec 15, 2017

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) removed README.md from this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Dec 15, 2017
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 462833b into PowerShell:master Dec 15, 2017
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the install-winarm branch December 15, 2017 22:25
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 19, 2017
@SteveL-MSFT @TravisEz13
Add instructions to deploy win-arm build on Windows IoT (PowerShell#5682
dbad0e7 
)
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 19, 2017
Merge 6.0.0-ga PRs #5713
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 19, 2017
@SteveL-MSFT @TravisEz13
Add instructions to deploy win-arm build on Windows IoT (#5682)
5058894
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @daxian-dbw
Add instructions to deploy win-arm build on Windows IoT (PowerShell#5682
2d9fe51 
)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @TravisEz13
Add instructions to deploy win-arm build on Windows IoT (PowerShell#5682
4a610d3 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+1 more reviewer
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@SteveL-MSFT @daxian-dbw @anmenaga
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.