GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Replace http.lee.io Tests with WebListener. by markekraus · Pull Request #5709 · PowerShell/PowerShell

Conversation

@markekraus

@markekraus Mark Kraus (markekraus) commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

PR Summary

  • Replaces http.lee.io tests with WebListener
  • 🎉 Closes Tests should not rely on external websites which lead to random failures #2504 🎉

PR Checklist

Note: Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • NA User facing Documentation needed
    • NA Issue filed - Issue link:
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] if the change is significant or affectes feature tests
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iSazonov and daxian-dbw reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@markekraus
[Feature] Replace lee.io Tests with WebListener.
97941ac
@markekraus Mark Kraus (markekraus) changed the title [Feature] Replace lee.io Tests with WebListener. Replace lee.io Tests with WebListener. Dec 18, 2017
@markekraus Mark Kraus (markekraus) changed the title Replace lee.io Tests with WebListener. Replace http.lee.io Tests with WebListener. Dec 18, 2017
iSazonov
Ilya (iSazonov) approved these changes Dec 18, 2017
View reviewed changes
@iSazonov
Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT) and Travis Plunk (TravisEz13) December 18, 2017 19:27
@iSazonov Ilya (iSazonov) self-assigned this Dec 18, 2017
TravisEz13
Travis Plunk (TravisEz13) approved these changes Dec 18, 2017
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 79ae396 into PowerShell:master Dec 19, 2017
@TravisEz13 Travis Plunk (TravisEz13) added this to the 6.0.0-GA milestone Dec 20, 2017
Travis Plunk (TravisEz13) pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 21, 2017
@markekraus @TravisEz13
[Feature] Replace lee.io Tests with WebListener. (PowerShell#5709)
c0540e2
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Dec 21, 2017
Merge 6.0.0 ga changes #5729
Merged
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Dec 21, 2017
@markekraus @TravisEz13
[Feature] Replace lee.io Tests with WebListener. (#5709)
52cadf9
@markekraus
Mark Kraus (markekraus) deleted the ReplaceLeeIo branch January 19, 2018 18:59
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @iSazonov
[Feature] Replace lee.io Tests with WebListener. (PowerShell#5709)
efc1ab5
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@markekraus @TravisEz13
[Feature] Replace lee.io Tests with WebListener. (PowerShell#5709)
640646e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.

Tests should not rely on external websites which lead to random failures

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markekraus @TravisEz13 @iSazonov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.