GeezerVison is showing github.com — Remove sc alias which conflicts with sc.exe by SteveL-MSFT · Pull Request #5827 · PowerShell/PowerShell
Conversation
PR Summary
SC is a default alias for Set-Content, however on Windows there is a sc.exe command for managing NT Services.
If a user executes sc start service1 in a PowerShell script, what happens is that a file called start is created containing service1 as the content with no error so the user/script may think the service got started.
In addition, there is also a sc command on Linux, although it's not installed by default.
If the customer feedback is that we should not have removed this, it'll be easier to add it back in 6.1.0 than to ever try to remove it after 6.0.0.
Fix is to remove sc alias from InitialSessionState and corresponding test case.
This was discussed with some members of @PowerShell/powershell-committee whom agreed to the removal.
Doc change MicrosoftDocs/PowerShell-Docs#2021
Fix #3980
PR Checklist
Note: Please mark anything not applicable to this PR NA.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mklement0 and shangzhi-hong reacted with thumbs up emoji
Jaykul and johndog reacted with thumbs down emoji
Jaykul reacted with confused emoji
All reactions
-
👍
2 reactions
-
👎
2 reactions
-
😕
1 reaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows PowerShell only aliases are also included here so this table is a complete source of alias changes. So maybe this entry should be kept and only change the 4th column to be $($FullCLR ) like scb.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
TravisEz13 reacted with thumbs up emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll make that change until we completely remove the Windows PowerShell code :)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|