GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Windows Event Log channel isolation semantics by Robo210 · Pull Request #6956 · PowerShell/PowerShell

Conversation

@Robo210

@Robo210 Kyle Sabo (Robo210) commented May 30, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove isolation attribute from Analytic and Debug channels. These channel types always have an isolation of Custom, regardless of what is put here in the manifest.

Since no events are being written to the Admin channel currently, remove it. This avoids the Windows Event Log pre-allocating a file for the channel.

PR Summary

Avoid setting incorrect values in the ETW manifest that get silently ignored by mc/wevtutil.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Robo210
Update PowerShell.Core.Instrumentation.man
4b28b23 
Remove isolation attribute from Analytic and Debug channels. These channel types always have an isolation of Custom.

The Admin channel was enabled by default, but the comments for the channel indicated that it should be off by default and thus it is OK to use a huge file size and have it stop collecting events when the size is reached. This looks like a copy/paste error where the logging element was copied from a channel with a different isolation type, so fix it by duplicating the Operational channel's logging element instead.

Since no events are being written to the Admin channel currently, set it to disabled by default.
@iSazonov
Ilya (iSazonov) requested a review from Dan Travison (dantraMSFT) May 30, 2018 09:53
@iSazonov Ilya (iSazonov) self-assigned this May 30, 2018
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jun 6, 2018
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kyle Sabo (@Robo210)!
The changes look good to me.
Dan Travison (@dantraMSFT) Can you please take a look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dantraMSFT
Dan Travison (dantraMSFT) suggested changes Jun 6, 2018
View reviewed changes

@dantraMSFT Dan Travison (dantraMSFT) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason to have an admin channel, it's not used for any events and I see no indication that it will change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/PowerShell.Core.Instrumentation/PowerShell.Core.Instrumentation.man Outdated
@@ -2264,23 +2265,19 @@
</channel>
<channel
chid="C_ADMIN"

@dantraMSFT Dan Travison (dantraMSFT) Jun 6, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no events referencing this channel, it should simply be removed, not disabled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Robo210
Remove admin channel
a780a9f 
The admin channel is not used by any events, so remove it.
dantraMSFT
Dan Travison (dantraMSFT) reviewed Jun 6, 2018
View reviewed changes
Comment thread src/PowerShell.Core.Instrumentation/PowerShell.Core.Instrumentation.man Outdated
</events>
<channels>
<!--There are two channels defined for Windows PowerShell instrumentation
<!--There are four channels defined for Windows PowerShell instrumentation

@dantraMSFT Dan Travison (dantraMSFT) Jun 6, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have mentioned this before, you'll want to remove these comments around Admin as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Robo210
Update PowerShell.Core.Instrumentation.man
70d054b
@iSazonov

Ilya (iSazonov) commented Jun 8, 2018

Copy link
Copy Markdown
Collaborator

Reopen The PR to restart CI Appveyor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) closed this Jun 8, 2018
@iSazonov Ilya (iSazonov) reopened this Jun 8, 2018
@iSazonov

Ilya (iSazonov) commented Jun 13, 2018

Copy link
Copy Markdown
Collaborator

Dan Travison (@dantraMSFT) Please update your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Jun 14, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 79ae17a into PowerShell:master Jun 14, 2018
@iSazonov

Ilya (iSazonov) commented Jun 14, 2018

Copy link
Copy Markdown
Collaborator

Kyle Sabo (@Robo210) Thanks for your contribution!
daxian-dbw reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Apr 20, 2026
Update the ETW manifest file to converge the changes from PowerShell repo PowerShell/PowerShell-Native#112
Merged
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@Robo210 @iSazonov
Fix Windows Event Log channel isolation semantics (PowerShell#6956)
5f355b2 
- Remove isolation attribute from Analytic and Debug channels. These channel types always have an isolation of Custom, regardless of what is put here in the manifest.

- Since no events are being written to the Admin channel currently, remove it. This avoids the Windows Event Log pre-allocating a file for the channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
+1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Robo210 @iSazonov @daxian-dbw @dantraMSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.