GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow .exe files to be used as binary modules by BrucePay · Pull Request #7281 · PowerShell/PowerShell

Conversation

@BrucePay

@BrucePay Bruce Payette (BrucePay) commented Jul 12, 2018 •
edited by TravisEz13
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Fix for #6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister reacted with hooray emoji kirillkovalenko reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
@BrucePay
Bruce Payette (BrucePay) requested a review from Dongbo Wang (daxian-dbw) as a code owner July 12, 2018 21:25
iSazonov
Ilya (iSazonov) reviewed Jul 13, 2018
View reviewed changes
Comment thread src/System.Management.Automation/engine/SessionStateStrings.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
iSazonov
Ilya (iSazonov) approved these changes Jul 16, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With two minor comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Jul 18, 2018
@TravisEz13 Travis Plunk (TravisEz13) changed the title Fix for #6741 Allow .exe files to be used as binary modules Allow .exe files to be used as binary modules Jul 18, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 18, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Per the contribution guidelines, the issues number you are fixing should not be in the PR Title, only the description. Including it causes us to have to edit it out later when authoring the changelog.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) approved these changes Jul 27, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 27, 2018
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/AnalysisCache.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/System.Management.Automation/engine/SessionStateStrings.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Aug 26, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Aug 26, 2018
@iSazonov

Ilya (iSazonov) commented Aug 27, 2018

Copy link
Copy Markdown
Collaborator

Up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Aug 27, 2018
@anmenaga

Andrew (anmenaga) commented Sep 18, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) can you please answer Steve's questions? Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Oct 18, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Oct 18, 2018
@iSazonov

Ilya (iSazonov) commented Oct 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Up. Need rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Oct 19, 2018
@anmenaga

Andrew (anmenaga) commented Oct 29, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) friendly ping.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@anmenaga

Andrew (anmenaga) commented Nov 28, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) friendly ping.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Dec 28, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Dec 28, 2018
@iSazonov

Ilya (iSazonov) commented Jan 6, 2019

Copy link
Copy Markdown
Collaborator

Bruce Payette (@BrucePay) Steve Lee (@SteveL-MSFT) Do we still want to have this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Jan 6, 2019
@stale

stale Bot commented Feb 5, 2019

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Feb 5, 2019
Bruce Payette and others added 4 commits February 5, 2019 12:27
Bruce Payette @SteveL-MSFT
Fix for PowerShell#6741 Allow .exe files to be used as binary modules
108f364
Bruce Payette @SteveL-MSFT
added trailing dot to a comment
176be60
Andrew Menagarishvili @SteveL-MSFT
minor feedback fixes
93db07c
@SteveL-MSFT
[feature] address my comments
f309808
@SteveL-MSFT
Steve Lee (SteveL-MSFT) force-pushed the brucepay_ImportExe branch from 88695ba to f309808 Compare February 5, 2019 20:27
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Feb 5, 2019
View reviewed changes
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 5, 2019

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) The build failed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13 Travis Plunk (TravisEz13) added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed Stale labels Feb 5, 2019
@SteveL-MSFT
[feature] test fixes, code factor fixes, fix merge conflict resolution
f401ea3
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 5, 2019

Copy link
Copy Markdown
Member

The remaining CodeFactor issues are not related to changes in this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt
Rob Holt (rjmholt) approved these changes Feb 5, 2019
View reviewed changes
TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 6, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT
[feature] address Travis' feedback
75b9d7d
@iSazonov

Ilya (iSazonov) commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) CI-Windows stll fail :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 6, 2019

Copy link
Copy Markdown
Member

Ilya (@iSazonov) the test failure is unrelated to this change but something we've been seeing for Enter-PSHostProcess. We should mark that test as pending in a separate PR to understand why it's inconsistent.
iSazonov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13
Travis Plunk (TravisEz13) merged commit 6bc6257 into PowerShell:master Feb 7, 2019
@iSazonov Ilya (iSazonov) mentioned this pull request Apr 17, 2019
Suggestion: Powershell should be able to Import-Module from an exe #3102
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Bruce Payette @TravisEz13
Allow .exe files to be used as IL binary modules (PowerShell#7281)
f045979 
Fix for PowerShell#6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@BrucePay @TravisEz13 @iSazonov @anmenaga @SteveL-MSFT @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.