GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add .editorconfig by iSazonov · Pull Request #7357 · PowerShell/PowerShell

Conversation

Ilya (iSazonov) commented Jul 25, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

PR Summary

Related #4708.

The .editorconfig file can be used by various editors and tools like Visual Studio and CodeFormatter.

The .editorconfig comes from Roslyn and CoreFX repositories:
https://github.com/dotnet/corefx/blob/master/.editorconfig
https://github.com/dotnet/roslyn/blob/master/.editorconfig

Description http://EditorConfig.org

Options https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixfbecker reacted with thumbs up emoji

All reactions

👍 1 reaction

Ilya (iSazonov) self-assigned this

Jul 25, 2018

Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Dongbo Wang (daxian-dbw)

July 25, 2018 11:42

Travis Plunk (TravisEz13) reviewed

Jul 27, 2018

View reviewed changes

Comment thread

.editorconfig Outdated

Travis Plunk (TravisEz13) Jul 27, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in our style: https://github.com/PowerShell/PowerShell/blob/master/docs/dev-process/coding-guidelines.md

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) Jul 30, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify? We have in the guideline:

Use _camelCase to name internal and private fields and use readonly where possible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) Jul 30, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have misread the guidance. Resolved

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) commented Jul 27, 2018

Copy link

Copy Markdown

Member

some of these conflict with style cop rules. It would be good to make them consistent (disable the conflicting rules)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Jul 30, 2018

Copy link

Copy Markdown

Collaborator Author

I believe we have already gained experience with StyleCop and we can turn off a few more rules. But first I would like to make some PR with CodeFormatting and style fixes so that we see the state of things more clearly. Also I guess CodeFormatter will use the .editorconfig file.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) commented Jul 30, 2018

Copy link

Copy Markdown

Member

Many of the naming rules, especially for non-public fields, conflict with the style cop rules. I believe those rules should be disabled before we add a file that defines conflicting rules.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stale Bot commented Aug 29, 2018

Copy link

Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stale Bot added the Stale label

Aug 29, 2018

Ilya (iSazonov) commented Aug 30, 2018

Copy link

Copy Markdown

Collaborator Author

Steve Lee (@SteveL-MSFT) Could you please share plans about fixing style issues?
My suggetion is to spend 1-2 weeks and fix as many style issues as we need, adjust and approve StyleCop and .editorconfig rules, reformat all code with CodeFormatter. After that we can return to normal contributing process with minimal style issue pressure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stale Bot removed the Stale label

Aug 30, 2018

Steve Lee (SteveL-MSFT) commented Aug 31, 2018

Copy link

Copy Markdown

Member

Ilya (@iSazonov) I think after GA of 6.1 would be the best time to bulk address style issues to have consistency. We're still targeting mid Sept for GA, so perhaps we can postpone this until then.

iSazonov reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Andrew (anmenaga) commented Sep 18, 2018

Copy link

Copy Markdown

Steve Lee (@SteveL-MSFT) GA shipped; it's time to look at this. :)

SteveL-MSFT reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add .editorconfig

54c0de2

The .editorconfig comes from Roslyn and CoreFX repositories:
https://github.com/dotnet/corefx/blob/master/.editorconfig
https://github.com/dotnet/roslyn/blob/master/.editorconfig

Ilya (iSazonov) force-pushed the add-editorconfig branch from bda45b9 to 54c0de2 Compare

September 19, 2018 08:07

Ilya (iSazonov) commented Sep 19, 2018

Copy link

Copy Markdown

Collaborator Author

Rebased to update CIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Steve Lee (SteveL-MSFT) requested changes

Sep 24, 2018

View reviewed changes

Comment thread

.editorconfig Outdated

		# (Please don't specify an indent_size here; that has too many unintended consequences.)

		# Code files
		[*.{cs,csx,vb,vbx}]

Steve Lee (SteveL-MSFT) Sep 24, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any vb code, but we do have cpp.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) Sep 25, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.editorconfig Outdated

		charset = utf-8

		# Xml project files
		[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]

Steve Lee (SteveL-MSFT) Sep 24, 2018

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about ps1xml files? Should we remove extensions we don't use in this repo?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) Sep 25, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added resx,ps1xml. Removed unused.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Address feedback about extensions

282619e

Steve Lee (SteveL-MSFT) approved these changes

Sep 26, 2018

View reviewed changes

Ilya (iSazonov) commented Sep 26, 2018

Copy link

Copy Markdown

Collaborator Author

Travis Plunk (@TravisEz13) Can we merge? Or we should address

some of these conflict with style cop rules. It would be good to make them consistent (disable the conflicting rules)

If .editorconfig rules is ok we could continue with style cop rules in follow PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) merged commit 3b9f758 into PowerShell:master

Oct 1, 2018

Ilya (iSazonov) deleted the add-editorconfig branch

October 2, 2018 03:16

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request

Jan 19, 2020


          vscode: Enable EditorConfig support in OmniSharp

0da816c

Enable support for EditorConfig in OmniSharp. Since omnisharp-roslyn version 1.33.0, OmniSharp has had this support.

* https://github.com/OmniSharp/omnisharp-roslyn/blob/master/CHANGELOG.md#1330---2019-07-01
* PowerShell#7357
* OmniSharp/omnisharp-roslyn#1526

xtqqczze mentioned this pull request

Jan 19, 2020

vscode: Enable EditorConfig support in OmniSharp #11627

Merged

8 tasks done

xtqqczze mentioned this pull request

Jun 2, 2020

Add missing .editorconfig settings present in dotnet/runtime #12871

Merged

8 of 14 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Add .editorconfig (PowerShell#7357)

a9631ef

Related PowerShell#4708.

The .editorconfig file can be used by various editors and tools like Visual Studio and CodeFormatter.

The .editorconfig comes from Roslyn and CoreFX repositories:
https://github.com/dotnet/corefx/blob/master/.editorconfig
https://github.com/dotnet/roslyn/blob/master/.editorconfig

Description http://EditorConfig.org

Options https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 left review comments

Steve Lee (SteveL-MSFT)

SteveL-MSFT approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Aditya Patwardhan (adityapatwardhan)

Awaiting requested review from adityapatwardhan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

Ilya (iSazonov) commented Jul 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Jul 27, 2018

Uh oh!

Ilya (iSazonov) commented Jul 30, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Jul 30, 2018

Uh oh!

stale Bot commented Aug 29, 2018

Uh oh!

Ilya (iSazonov) commented Aug 30, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Aug 31, 2018

Uh oh!

Andrew (anmenaga) commented Sep 18, 2018

Uh oh!

Ilya (iSazonov) commented Sep 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Sep 26, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ilya (iSazonov) commented Jul 25, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.