GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove empty xml comment lines by iSazonov · Pull Request #7401 · PowerShell/PowerShell

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Jul 30, 2018

Copy link
Copy Markdown
Collaborator

PR Summary

Instead of #7356.

Please review commit by commit.

  • The PR only remove empty public comment XML lines. Please don't request other changes.
  • The changes were made in Notepad++ by regex.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ilya (iSazonov) added 15 commits July 30, 2018 09:24
@iSazonov
Remove 1
3eacbcf
@iSazonov
Remove 2
add6649
@iSazonov
Remove 3
831cc1f
@iSazonov
Remove 4
454abc6
@iSazonov
Remove 5
b4ed616
@iSazonov
Remove 6
3542ae6
@iSazonov
Remove 7
6932b94
@iSazonov
Remove 8
fd9901e
@iSazonov
Remove 11
6844f1c
@iSazonov
Remove 10
c9345c5
@iSazonov
Remove 10
be3b168
@iSazonov
Remove 12
8bd47c5
@iSazonov
Remove 13
fe8692a
@iSazonov
Remove 14
a055e59
@iSazonov
Remove 15
fd8f7ec
@iSazonov Ilya (iSazonov) self-assigned this Jul 30, 2018
@iSazonov
Ilya (iSazonov) requested a review from Steve Lee (SteveL-MSFT) July 30, 2018 04:50
@iSazonov
Ilya (iSazonov) requested review from Bruce Payette (BrucePay), Francisco Gamino (Francisco-Gamino), James Truher (JamesWTruher), Paul Higinbotham (PaulHigin), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT), Dongbo Wang (daxian-dbw) and Mike Richmond (mirichmo) as code owners July 30, 2018 04:50
@iSazonov Ilya (iSazonov) mentioned this pull request Jul 30, 2018
Remove empty xml comment lines #7356
Closed
7 of 11 tasks
@iSazonov
Merge branch 'master' into remove-empty-xml-comment-lines1
3068d61
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 31, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/ReadConsoleCmdlet.cs Outdated
/// <summary>
///
/// Retrieves input from the host virtual console and writes it to the pipeline output.
///

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regular expression should remove this whitespace unless the line after the whitespace contains text and not <.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ilya (iSazonov) added 4 commits July 31, 2018 08:25
@iSazonov
Remove tail 1
2cb5f23
@iSazonov
Remove tail 2
5af1144
@iSazonov
Remove tail 3
93f37bc
@iSazonov
Remove tail 4
7dce9af
SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 31, 2018
View reviewed changes

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ilya (@iSazonov) I appreciate your passion to clean up the code, but perhaps we should discuss whether it's worth the review effort next time before you start a. PR as this was review took significant time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/Microsoft.PowerShell.Security/security/CertificateProvider.cs Outdated
/// <exception cref="System.ArgumentException">
/// path is null or empty.
/// </exception>
///

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems broken EOL.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/FormatAndOutput/common/ILineOutput.cs
/// start the playback
/// </summary>
internal virtual void ExecuteBufferPlayBack(DoPlayBackCall playback) { }

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace should probably stay

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/FormatAndOutput/out-console/OutConsole.cs
using System.Management.Automation.Host;
using System.Management.Automation.Internal;
using Microsoft.PowerShell.Commands.Internal.Format;

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put back this whitespace

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/FormatAndOutput/out-console/OutConsole.cs
/// </summary>
[Parameter(ValueFromPipeline = true)]
public PSObject InputObject { set; get; } = AutomationNull.Value;

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put back this whitespace

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/System.Management.Automation/engine/CommandProcessorBase.cs Outdated
/// True if read succeeds.
/// </returns>
///
/// does not throw

@SteveL-MSFT Steve Lee (SteveL-MSFT) Jul 31, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to inside the <summary/>?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iSazonov Ilya (iSazonov) Jul 31, 2018

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov
Address feedback
88e23f5
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jul 31, 2018
View reviewed changes
@iSazonov

Ilya (iSazonov) commented Aug 1, 2018

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) We already have a tracking Issue but haven't plan. With the plan we'd freeze current PRs and spend 1-2 weeks to fix as many style issues as possible.
SteveL-MSFT reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov Ilya (iSazonov) changed the title Remove empty xml comment lines1 Remove empty xml comment lines Aug 1, 2018
@iSazonov
Ilya (iSazonov) merged commit 5d03e16 into PowerShell:master Aug 1, 2018
@iSazonov
Ilya (iSazonov) deleted the remove-empty-xml-comment-lines1 branch August 1, 2018 05:39
@kvprasoon PRASOON KARUNAN V (kvprasoon) mentioned this pull request Aug 27, 2018
Remove empty xml comment lines(missed in #7401) #7641
Merged
7 of 11 tasks
Ilya (iSazonov) pushed a commit that referenced this pull request Aug 28, 2018
@kvprasoon @iSazonov
Remove empty xml comment lines(missed in #7401) (#7641)
2b61159
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Aug 28, 2018
@kvprasoon @TravisEz13
Remove empty xml comment lines(missed in #7401) (#7641)
91b3047
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov
Remove empty xml comment lines (PowerShell#7401)
0606f1d
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kvprasoon @iSazonov
Remove empty xml comment lines(missed in PowerShell#7401) (PowerShell…
707b6fa 
…#7641)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kvprasoon @TravisEz13
Remove empty xml comment lines(missed in PowerShell#7401) (PowerShell…
984f46f 
…#7641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@Francisco-Gamino Francisco Gamino (Francisco-Gamino) Awaiting requested review from Francisco-Gamino
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@mirichmo Mike Richmond (mirichmo) Awaiting requested review from mirichmo
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iSazonov @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.