GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add script to create icns files. by thezim · Pull Request #7456 · PowerShell/PowerShell

Conversation

@thezim

@thezim Greg Zimmerman (thezim) commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Add script to generate macOS icon file. It does not attempt to integrate with the current build process as the macOS icon file is mostly static.

libsvg was chosen because of its low dependency count over other solutions that use backends like Chromium, PhontomJS, etc. ImageMagick's convert was tested but resulting PNGs where not satisfactory and would have required an overcomplicated script having to calculate the density argument.

  • Has a dependency on librsvg (can be installed via Brew)
  • Uses SVG file as input
  • Can be integrated in later to build process if desired

Closes #7455

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thezim
Add script to create icns files.
ee16f6e
@thezim
Greg Zimmerman (thezim) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners August 6, 2018 00:27
@TravisEz13 Travis Plunk (TravisEz13) self-assigned this Aug 7, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 7, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Does this need to be in our repo? This will take a significant about of time to review due to the use of librsvg. Just asking, I've already started the review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thezim

Greg Zimmerman (thezim) commented Aug 7, 2018

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) The intent was to have the knowledge in this repo in case someone else needed to generate the icns files for the project due to an icon asset change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 7, 2018

Copy link
Copy Markdown
Member

It's probably the right thing to do. The tool uses a GPL license and will take some time to get approval to use the tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dantraMSFT Dan Travison (dantraMSFT) added the Review - Needed The PR is being reviewed label Aug 13, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 20, 2018

Copy link
Copy Markdown
Member

Sorry, still waiting on the review here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Sep 19, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Sep 19, 2018
@anmenaga

Andrew (anmenaga) commented Sep 19, 2018

Copy link
Copy Markdown

Travis Plunk (@TravisEz13) how do we currently generate macOS icon file?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Sep 19, 2018
@thezim

Greg Zimmerman (thezim) commented Sep 19, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Andrew (@anmenaga) I generated both of the current ones. This was a manual process. Export PNGs from the SVG to proper names and resolutions, then use iconutil to assemble the asset.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 19, 2018

Copy link
Copy Markdown
Member

Yup, I just checked the internal review and it is still ongoing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Oct 19, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Oct 19, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Oct 20, 2018

Copy link
Copy Markdown
Member

Sorry, still in review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Oct 20, 2018
@stale

stale Bot commented Nov 19, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Nov 19, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 19, 2018

Copy link
Copy Markdown
Member

Sorry, still in review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Nov 19, 2018
@TravisEz13 Travis Plunk (TravisEz13) removed the Review - Needed The PR is being reviewed label Nov 19, 2018
@TravisEz13
Travis Plunk (TravisEz13) removed the request for review from Dan Travison (dantraMSFT) November 27, 2018 02:24
@TravisEz13

Travis Plunk (TravisEz13) commented Nov 27, 2018

Copy link
Copy Markdown
Member

Greg Zimmerman (@thezim) could you push a new commit to update the CI status here? The internal review finally looks like it is finishing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thezim
Trigger CI build
423b287
@thezim
Greg Zimmerman (thezim) requested a review from Paul Higinbotham (PaulHigin) as a code owner November 29, 2018 20:21
@thezim

Greg Zimmerman (thezim) commented Nov 29, 2018

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Dec 30, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Dec 30, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Jan 2, 2019
View reviewed changes
@stale stale Bot removed the Stale label Jan 2, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit 2a1b6ed into PowerShell:master Jan 2, 2019
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 2, 2019
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@thezim @TravisEz13
Add script to create icns files. (PowerShell#7456)
50ff882 
Add script to generate macOS icon file. It does not attempt to integrate with the current build process as the macOS icon file is mostly static.

`libsvg` was chosen because of its low dependency count over other solutions that use backends like Chromium, PhontomJS, etc. ImageMagick's `convert` was tested but resulting PNGs where not satisfactory and would have required an overcomplicated script having to calculate the `density` argument.

* Has a dependency on librsvg (can be installed via Brew)
* Uses SVG file as input
* Can be integrated in later to build process if desired

Closes PowerShell#7455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create automated way to create macOS icon.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@thezim @TravisEz13 @anmenaga @dantraMSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.