GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update .Net Core/SDK docs about version 2.0 to be about version 2.x by bergmeister · Pull Request #7467 · PowerShell/PowerShell

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Aug 6, 2018

Copy link
Copy Markdown
Contributor

PR Summary

As per title. Due to the upgrade to .Net Core 2.1 in 6.1, it is better to not be specific about the version of .Net Core or the SDK.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bergmeister
update .net core/sdk docs about version 2.0 to be about version 2.x
ff722db
@bergmeister
Christoph Bergmeister (bergmeister) requested review from Hemant Mahawar (HemantMahawar), Steve Lee (SteveL-MSFT), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT), Dongbo Wang (daxian-dbw) and Joey Aiello (joeyaiello) as code owners August 6, 2018 22:29
@TravisEz13

Travis Plunk (TravisEz13) commented Aug 6, 2018

Copy link
Copy Markdown
Member

there are spelling failures in travis-ci
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister) added 2 commits August 7, 2018 07:42
@bergmeister
add 2.x to spelling list
83d6cdb
@bergmeister
Add 2.x. to the list of allowed spellings
f166901
@bergmeister

Christoph Bergmeister (bergmeister) commented Aug 7, 2018

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) I addressed the spelling issues.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 7, 2018
View reviewed changes
@daxian-dbw Dongbo Wang (daxian-dbw) self-assigned this Aug 7, 2018
TravisEz13
Travis Plunk (TravisEz13) approved these changes Aug 7, 2018
View reviewed changes
dantraMSFT
Dan Travison (dantraMSFT) suggested changes Aug 7, 2018
View reviewed changes
Comment thread docs/building/macos.md
building on macOS is almost identical.

.NET Core 2.0 (and by transitivity, us) only supports macOS 10.12+.
.NET Core 2.x (and by transitivity, us) only supports macOS 10.12+.

@dantraMSFT Dan Travison (dantraMSFT) Aug 7, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the third bullet item also need to be changed?

Downloads and installs a preview version of .NET Core SDK 2.0 to ~/.dotnet

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread docs/cmdlet-example/command-line-simple-example.md
@@ -171,7 +171,7 @@ can't find the `netstandard.dll` "implementation" assembly for the version of th

### The fix for missing netstandard.dll

@dantraMSFT Dan Travison (dantraMSFT) Aug 7, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are stale references to 2.0 in this section. Two that stand out are

  • "Install the .NET Core SDK 2.0 for Windows, if it isn't already installed."
    This actually links to the .NET Core 2.1 page. Perhaps updating the link label to also use 2.x

  • Copy-Item 'C:\Program Files\dotnet\sdk\2.0.0\Microsoft...
    A note about the version number varying might help so users arent' blindly copy/pasting the text and getting errors.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@daxian-dbw
Address Dan's comment
697c037
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Aug 30, 2018

Copy link
Copy Markdown
Member

Dan Travison (@dantraMSFT) I pushed a commit to address your comments. Please take another look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Aug 30, 2018
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit b3c961f into PowerShell:master Aug 30, 2018
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Aug 31, 2018
@bergmeister @TravisEz13
Update docs about .NET Core version 2.0 to be about version 2.x (#7467)
e4cb8e1
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Aug 31, 2018
@bergmeister

Christoph Bergmeister (bergmeister) commented Sep 2, 2018

Copy link
Copy Markdown
Contributor Author

Dongbo Wang (@daxian-dbw) Thanks for helping out, I was quite busy the last weeks due to moving house and forgot about this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 4, 2018

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) No worries, that's what we maintainers do 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @daxian-dbw
Update docs about .NET Core version 2.0 to be about version 2.x (Powe…
e7691fb 
…rShell#7467)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @TravisEz13
Update docs about .NET Core version 2.0 to be about version 2.x (Powe…
1eaff9f 
…rShell#7467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@HemantMahawar Hemant Mahawar (HemantMahawar) Awaiting requested review from HemantMahawar
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
+1 more reviewer
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bergmeister @TravisEz13 @daxian-dbw @dantraMSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.