GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add tests for Import-Module -Force by rjmholt · Pull Request #7491 · PowerShell/PowerShell

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Aug 9, 2018

Copy link
Copy Markdown
Collaborator

PR Summary

Add testing for the behaviour of Import-Module -Force.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iSazonov
Ilya (iSazonov) approved these changes Aug 10, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated

@iSazonov Ilya (iSazonov) Aug 10, 2018

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -Tag "CI".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@rjmholt Rob Holt (rjmholt) changed the title Add tests for Import-Module -Force WIP: Add more tests for Import-Module Aug 10, 2018
@rjmholt

Rob Holt (rjmholt) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

Sorry Ilya (@iSazonov), I was demonstrating to some people how to contribute simple tests to the PowerShell repo.

But I would actually like to add this test and bunch of others, so I'll add a few more to this and we can make it into a more useful PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

We could merge this as is. You can make new PR for new tests.
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt Rob Holt (rjmholt) changed the title WIP: Add more tests for Import-Module Add tests for Import-Module -Force Aug 10, 2018
@rjmholt

Rob Holt (rjmholt) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

Ilya (@iSazonov) Done!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov
Ilya (iSazonov) requested a review from Aditya Patwardhan (adityapatwardhan) August 12, 2018 13:54
@iSazonov

Ilya (iSazonov) commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

I guess you will add tests for nested module scenarios with -Force.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iSazonov

Ilya (iSazonov) commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) Could you please review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 30, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 30, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iSazonov Ilya (iSazonov) self-assigned this Aug 30, 2018
@iSazonov

Ilya (iSazonov) commented Sep 17, 2018

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt) Please rebase to reconfigure CIs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Robert Holt added 3 commits September 17, 2018 13:52
Robert Holt
Add tests for Import-Module -Force
323acd7
Robert Holt
Address PR feedback
55cf4d5
Robert Holt
Address PR feedback
1d7b1f1
@rjmholt
Rob Holt (rjmholt) force-pushed the import-module-force-tests branch from c35b5f2 to 1d7b1f1 Compare September 17, 2018 20:54
Robert Holt
Add CI tag
014a6cd
@iSazonov

Ilya (iSazonov) commented Sep 18, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) Please update your code review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Sep 18, 2018
View reviewed changes
@iSazonov
Ilya (iSazonov) merged commit 3c67fa3 into PowerShell:master Sep 19, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@rjmholt @iSazonov
Add tests for Import-Module -Force (PowerShell#7491)
e96249c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rjmholt @iSazonov @adityapatwardhan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.