GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix Start-PSBuild -Output by kwkam · Pull Request #7504 · PowerShell/PowerShell

Conversation

@kwkam

@kwkam kwkam commented Aug 12, 2018 •
edited by TravisEz13
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Make Start-PSBuild -Output $OutDir output the build to the directory properly.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link:
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kwkam
build: fix Start-PSBuild -Output
69a07f3 
Make Start-PSBuild -Output $OutDir output the build to the directory
properly.
@kwkam
kwkam requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga), Dan Travison (dantraMSFT) and Dongbo Wang (daxian-dbw) as code owners August 12, 2018 04:58
iSazonov
Ilya (iSazonov) approved these changes Aug 13, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iSazonov Ilya (iSazonov) assigned Travis Plunk (TravisEz13) Aug 13, 2018
adityapatwardhan
Aditya Patwardhan (adityapatwardhan) approved these changes Aug 13, 2018
View reviewed changes
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Aug 13, 2018

Copy link
Copy Markdown
Member

Restarted Travis-CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dantraMSFT
Dan Travison (dantraMSFT) suggested changes Aug 13, 2018
View reviewed changes

@dantraMSFT Dan Travison (dantraMSFT) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be thought through a little more because it's not clear to the user what -Output should contain.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread build.psm1 Resolved

Uh oh!

There was an error while loading. Please reload this page.
anmenaga
Andrew (anmenaga) reviewed Aug 20, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PR description: to me it is not clear what is the current (bad) behavior is / what this PR is fixing. Maybe add a sentence about it or example.
  2. While you are at it and understand internals it would be great if you could add comments for $Output parameters of functions in build.psm1, describing expected values and behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kwkam
Add comment
a1a6d79
dantraMSFT
Dan Travison (dantraMSFT) approved these changes Sep 6, 2018
View reviewed changes
@kwkam
Merge branch 'master' into build-output
6f0f276
@TravisEz13

Travis Plunk (TravisEz13) commented Sep 13, 2018

Copy link
Copy Markdown
Member

AppVeyor timed out. Restarted it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale

stale Bot commented Oct 13, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot added the Stale label Oct 13, 2018
@iSazonov

Ilya (iSazonov) commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator

kwkam Please rebase to pass CIs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@stale stale Bot removed the Stale label Oct 15, 2018
@kwkam
Merge branch 'master' into build-output
aecb358
@kwkam
kwkam requested a review from Paul Higinbotham (PaulHigin) as a code owner October 19, 2018 12:34
TravisEz13
Travis Plunk (TravisEz13) approved these changes Oct 30, 2018
View reviewed changes
@TravisEz13
Travis Plunk (TravisEz13) merged commit a4d4c31 into PowerShell:master Oct 30, 2018
@kwkam
kwkam deleted the build-output branch January 11, 2019 15:06
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@kwkam @TravisEz13
build: fix Start-PSBuild -Output (PowerShell#7504)
852bb63 
Make Start-PSBuild -Output $OutDir output the build to the directory properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
+2 more reviewers
@anmenaga Andrew (anmenaga) anmenaga left review comments
@dantraMSFT Dan Travison (dantraMSFT) dantraMSFT approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kwkam @adityapatwardhan @TravisEz13 @iSazonov @anmenaga @dantraMSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.