GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use non virtual call of 'family or assembly' methods of base class. by yurko7 · Pull Request #7624 · PowerShell/PowerShell

Conversation

@yurko7

@yurko7 Yuriy Kushnir (yurko7) commented Aug 23, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Consider protected internal access modifier for non virtual calls of base class overridden methods.
Fix #7622

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: Impossible to call overridden protected internal method of base class. #7622
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

PowerShellTeam, looks like the fix falls into bucket 3 of breaking changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yurko7
Use non virtual call of 'family or assembly' methods of base class (P…
f08539f 
…owerShell#7622)
@yurko7
Yuriy Kushnir (yurko7) requested review from Bruce Payette (BrucePay) and Dongbo Wang (daxian-dbw) as code owners August 23, 2018 20:39
@iSazonov
Ilya (iSazonov) requested a review from Rob Holt (rjmholt) August 24, 2018 07:46
@iSazonov Ilya (iSazonov) assigned Dongbo Wang (daxian-dbw) Aug 24, 2018
rjmholt
Rob Holt (rjmholt) approved these changes Aug 24, 2018
View reviewed changes

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Aug 29, 2018
View reviewed changes
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 165f2c9 into PowerShell:master Aug 29, 2018
@iSazonov

Ilya (iSazonov) commented Aug 29, 2018

Copy link
Copy Markdown
Collaborator

Yuriy Kushnir (@yurko7) Thank you for the contribution!
yurko7 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Aug 31, 2018
@yurko7 @TravisEz13
Use non-virtual call to invoke 'family or assembly' methods on base c…
d8bb2e9 
…lass from PowerShell class (#7622) (#7624)
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Aug 31, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@yurko7 @daxian-dbw
Use non-virtual call to invoke 'family or assembly' methods on base c…
b3250c2 
…lass from PowerShell class (PowerShell#7622) (PowerShell#7624)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@yurko7 @TravisEz13
Use non-virtual call to invoke 'family or assembly' methods on base c…
05c03ef 
…lass from PowerShell class (PowerShell#7622) (PowerShell#7624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Impossible to call overridden protected internal method of base class.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@yurko7 @iSazonov @daxian-dbw @rjmholt @TravisEz13
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.