GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add %F option to Get-Date -UFormat by britishben · Pull Request #7630 · PowerShell/PowerShell

Conversation

@britishben

@britishben Benjamin P. McKenna (britishben) commented Aug 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

I got annoyed that Get-Date -UFormat '%F %T' did not work the same as date +'%F %T', so I've added that case now. Partial fix for issue #7341.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
  • User-facing changes
    • Not Applicable
    • OR
    • User-facing Documentation needed
      • Issue filed - Issue link: Add Get-Date '%F' option MicrosoftDocs/PowerShell-Docs#2959
  • Testing - New and feature
    • Not Applicable or can only be tested interactively
    • OR
    • Make sure you've added a new test if existing tests do not effectively test the code changed
      • Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@britishben
Benjamin P. McKenna (britishben) requested review from James Truher (JamesWTruher), Paul Higinbotham (PaulHigin) and Dan Travison (dantraMSFT) as code owners August 24, 2018 12:36
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Aug 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) reviewed Aug 24, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benjamin P. McKenna (@britishben) Thanks for your contribution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@britishben

Benjamin P. McKenna (britishben) commented Sep 4, 2018

Copy link
Copy Markdown
Contributor Author

Thanks chuanjiao10 - I've taken out the 'P' case now, so the only one of your cases this would solve is the first:

PS /root> get-date -uformat %F ; date +%F
F
2018-07-24

Still, slow progress is better than no progress.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben Benjamin P. McKenna (britishben) changed the title WIP: Add two options (%F, %P) to Get-Date -UFormat WIP: Add one option (%F) to Get-Date -UFormat Sep 4, 2018
@iSazonov

Ilya (iSazonov) commented Sep 4, 2018

Copy link
Copy Markdown
Collaborator

Benjamin P. McKenna (@britishben) If you don't plan fix %P please update the PR description and remove WIP.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben Benjamin P. McKenna (britishben) changed the title WIP: Add one option (%F) to Get-Date -UFormat Add %F option to Get-Date -UFormat Sep 24, 2018
@britishben

Benjamin P. McKenna (britishben) commented Sep 24, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Done - thanks for the reminder.

chuanjiao10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Sep 24, 2018

Copy link
Copy Markdown
Collaborator

Benjamin P. McKenna (@britishben) Please rebase to fix CIs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben

Benjamin P. McKenna (britishben) commented Sep 26, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) done, thanks - let me know if you need anything else from me.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Sep 26, 2018

Copy link
Copy Markdown
Collaborator

Please update package reference to Markdig.Signed 0.15.2 (see failed test)

Microsoft.PowerShell.MarkdownRender.csproj reference to Markdig.Signed 0.15.2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben
Benjamin P. McKenna (britishben) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners September 27, 2018 09:27
@britishben

Benjamin P. McKenna (britishben) commented Sep 27, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) I've bumped up the number in src/Microsoft.PowerShell.MarkdownRender/Microsoft.PowerShell.MarkdownRender.csproj to see if that makes a difference, but that's not my error; Looks like a version change from https://github.com/lunet-io/markdig/ (got 15.3, expected 15.2).

You'll probably see the same on all your PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Sep 27, 2018

Copy link
Copy Markdown
Collaborator

Benjamin P. McKenna (@britishben) Yes, it is not your error. We have a test to check package versions. If there is a new version the test fail. We already merged a PR with version updates. So you should rebase.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben
Add '%F' case to Get-Date -UFormat
115e181
Update tests to add %F
@britishben

Benjamin P. McKenna (britishben) commented Sep 27, 2018

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Thanks - done that now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iSazonov
Ilya (iSazonov) approved these changes Sep 27, 2018
View reviewed changes
@iSazonov Ilya (iSazonov) self-assigned this Sep 27, 2018
@iSazonov

Ilya (iSazonov) commented Sep 27, 2018

Copy link
Copy Markdown
Collaborator

Andrew (@anmenaga) Travis Plunk (@TravisEz13) Please review the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov

Ilya (iSazonov) commented Sep 27, 2018

Copy link
Copy Markdown
Collaborator

Benjamin P. McKenna (@britishben) Please open new issue in PowerSehll-Docs repo (or push PR there) to document the enhancement and add a link to the issue to the PR description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iSazonov Ilya (iSazonov) added the Documentation Needed in this repo Documentation is needed in this repo label Sep 27, 2018
@britishben Benjamin P. McKenna (britishben) mentioned this pull request Sep 27, 2018
Add Get-Date '%F' option MicrosoftDocs/PowerShell-Docs#2959
Merged
2 of 9 tasks
@iSazonov
Ilya (iSazonov) merged commit 39252b4 into PowerShell:master Oct 1, 2018
@iSazonov

Ilya (iSazonov) commented Oct 1, 2018

Copy link
Copy Markdown
Collaborator

Benjamin P. McKenna (@britishben) Thanks for your contribution!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@britishben
Benjamin P. McKenna (britishben) deleted the get-date-bpm branch October 1, 2018 15:30
@joeyaiello Joey Aiello (joeyaiello) mentioned this pull request Oct 15, 2018
Docs needed for 'Add %F option to Get-Date -UFormat' MicrosoftDocs/PowerShell-Docs#3029
Closed
@joeyaiello Joey Aiello (joeyaiello) removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 14, 2018
@britishben Sean Wheeler
Add Get-Date '%F' option
5afae5d
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 15, 2018
@britishben Sean Wheeler
Add Get-Date '%F' option
1e63c22
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Nov 16, 2018
@britishben Sean Wheeler
Add Get-Date '%F' option
2c64b06
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 5, 2018
@britishben Sean Wheeler
Add Get-Date '%F' option
9d67482
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Dec 20, 2018
@britishben @sdwheeler
Add Get-Date '%F' option
b031b6d
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 6, 2019
@britishben @sdwheeler
Add Get-Date '%F' option
73b4b39
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 11, 2019
@britishben Sean Wheeler
Add Get-Date '%F' option
eb145ca
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Jan 14, 2019
@britishben Sean Wheeler
Add Get-Date '%F' option
4da771a
Documentation update for PowerShell/PowerShell#7630
Alma Jenks (v-alje) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 1, 2019
@britishben @v-alje
Add Get-Date '%F' option
71788c3
Documentation update for PowerShell/PowerShell#7630
Sean Wheeler (sdwheeler) pushed a commit to MicrosoftDocs/PowerShell-Docs that referenced this pull request Feb 4, 2019
@britishben @sdwheeler
Add Get-Date '%F' option
ba7b3a0
Documentation update for PowerShell/PowerShell#7630
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@britishben @iSazonov
Add '%F' case to Get-Date -UFormat (PowerShell#7630)
7fe9c06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@dantraMSFT Dan Travison (dantraMSFT) Awaiting requested review from dantraMSFT
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@britishben @msftclas @iSazonov @joeyaiello
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.