GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Update to latest package references, runtime framework, and SDK by iSazonov · Pull Request #7646 · PowerShell/PowerShell

Conversation

Ilya (iSazonov) commented Aug 28, 2018

Copy link

Copy Markdown

Collaborator

PR Summary

Move to sdk2.1.401, runtime 2.1.3 and update package references.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- User-facing Documentation needed
  - Issue filed - Issue link:
Testing - New and feature
- Not Applicable or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] if the change is significant or affects feature tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Ilya (iSazonov) self-assigned this

Aug 28, 2018

Ilya (iSazonov) requested review from Steve Lee (SteveL-MSFT), Travis Plunk (TravisEz13) and Dongbo Wang (daxian-dbw)

August 28, 2018 10:17

Ilya (iSazonov) requested review from Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dan Travison (dantraMSFT) as code owners

August 28, 2018 10:17

Ilya (iSazonov) commented Aug 28, 2018

Copy link

Copy Markdown

Collaborator Author

CI Appveyor failed with "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found". I don't know how fix this.

Feel free to add commits.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) approved these changes

Aug 28, 2018

View reviewed changes

Travis Plunk (TravisEz13) requested changes

Aug 28, 2018

View reviewed changes

Travis Plunk (TravisEz13) left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files.wxs is still out of sync

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Travis Plunk (TravisEz13) commented Aug 29, 2018

Copy link

Copy Markdown

Member

the mac CI was failing due to a version number being in the TMPDIR I was setting. It looks like VSTS has already fixed this issue, so I removed this workaround.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) commented Aug 29, 2018

Copy link

Copy Markdown

Collaborator Author

Travis Plunk (@TravisEz13) Thanks for help!
I still see the error in CI Appveyor "dotnet : A compatible SDK version for global.json version: [2.1.401] from [C:\projects\powershell\global.json] was not found"
I think it is the reason that file.wxs is not synced.
I don't know how fix CI Appveyor.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) commented Aug 29, 2018

Copy link

Copy Markdown

Member

That isn't what's causing it to fail. See https://ci.appveyor.com/project/PowerShell/powershell/build/v6.1.0-rc.10858/job/e862tmmuqaww98v0#L1735

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) and others added 4 commits

August 30, 2018 17:46


          Move to .Net Core SDK 2.1.401 and runtime 2.1.3

4aeaf12


          Update package references

1950ac3


          Update files.wxs

95943a4


          Add new files to files.wxs

74f45f6

Travis Plunk (TravisEz13) force-pushed the move-to-sdk2.1.401 branch from 9b8fecc to 74f45f6 Compare

August 31, 2018 00:47

Travis Plunk (TravisEz13) approved these changes

Aug 31, 2018

View reviewed changes

Travis Plunk (TravisEz13) merged commit c34d3ef into PowerShell:master

Aug 31, 2018

Ilya (iSazonov) commented Aug 31, 2018

Copy link

Copy Markdown

Collaborator Author

Travis Plunk (@TravisEz13) Thanks for help!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ilya (iSazonov) deleted the move-to-sdk2.1.401 branch

August 31, 2018 03:01

Travis Plunk (TravisEz13) commented Aug 31, 2018

Copy link

Copy Markdown

Member

Ilya (@iSazonov) No problem... I used this to test my new code to generate the wxs file changes.

iSazonov reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Travis Plunk (TravisEz13) pushed a commit that referenced this pull request

Aug 31, 2018


          Update to latest package references, runtime framework, and SDK (#7646)

959ce30

* Move to .Net Core SDK 2.1.401 and runtime 2.1.3

* Update package references

Travis Plunk (TravisEz13) added this to the v6.1.0 milestone

Aug 31, 2018

Ilya (iSazonov) mentioned this pull request

Sep 6, 2018

Update PSReadLine to 2.0.0-beta3 #7711

Merged

7 of 11 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Update to latest package references, runtime framework, and SDK (Powe…

f06ea57

…rShell#7646)

* Move to .Net Core SDK 2.1.401 and runtime 2.1.3

* Update package references

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request

Aug 6, 2026


          Update to latest package references, runtime framework, and SDK (Powe…

3fc56ad

…rShell#7646)

* Move to .Net Core SDK 2.1.401 and runtime 2.1.3

* Update package references

Reviewers

Travis Plunk (TravisEz13)

TravisEz13 approved these changes

Dongbo Wang (daxian-dbw)

Awaiting requested review from daxian-dbw

Steve Lee (SteveL-MSFT)

Awaiting requested review from SteveL-MSFT

Aditya Patwardhan (adityapatwardhan)

Awaiting requested review from adityapatwardhan

Andrew (anmenaga)

Awaiting requested review from anmenaga

Dan Travison (dantraMSFT)

Awaiting requested review from dantraMSFT

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.